-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OkHttp to 4.10.0 #8624
Update OkHttp to 4.10.0 #8624
Conversation
Kudos, SonarCloud Quality Gate passed! |
I tested a while on emulator and it seems to work well. I looked mostly at the migration guide and there seems to be nothing specific we should do. The changelog included many things, but nothing that should touch us. See the findings hereafter. If you agree these are not problematic for us, then I am ok with merging this PR.
Other notable things (not important for this PR):
|
There's this, but idk if that still applies with the support drop for API 19.
We don't use okhttp-tls anyway, so that's fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
🙌 Anything interesting in the changelog? Any feature we're getting for free or something? |
No features, but a fix. The upgrade comes at the right time. However, we were not affected by the vul, but the incident shows that it's important to not use lib versions which run out of support. |
I'm surprised there isn't already a long list of known CVEs for the 3.12.13 version we were using. |
What is it?
Description of the changes in your PR
It would probably be good to get this done before a certain PR as well.
Read through the changelogs and see if anything else needs to be done. I did so, and didn't really find anything of interest, but check for yourselves anyway.
This PR adds around 227KB to the debug APK, and 75KB to the release APK.
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence