Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve image placeholders #8530

Merged
merged 9 commits into from
Jul 14, 2022
Merged

Improve image placeholders #8530

merged 9 commits into from
Jul 14, 2022

Commits on Jul 14, 2022

  1. Improve image placeholders 

    - Show placeholders until the image is loaded because timeout can be very long and missing profile pictures and video thumbnails make app inconvenient to use

- Adapt profile picture and video thumbnail placeholders to light theme

- Replace profile picture and video thumbnail placeholders with vector graphics
    @krlvm @Stypox
    krlvm authored and Stypox committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    cc7a8fb View commit details
    Browse the repository at this point in the history

  2. Use corresponding material icon in user profile thumbnail

    @krlvm @Stypox
    krlvm authored and Stypox committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    7b41acb View commit details
    Browse the repository at this point in the history

  3. Optimize thumbnail placeholder drawables

    @krlvm @Stypox
    krlvm authored and Stypox committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    429f253 View commit details
    Browse the repository at this point in the history

  4. Rename buddy.xml to dummy_person.xml

    @krlvm @Stypox
    krlvm authored and Stypox committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    35eeccd View commit details
    Browse the repository at this point in the history

  5. Fix swapped colors in video and playlist thumbnails

    @krlvm @Stypox
    krlvm authored and Stypox committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    dff1adb View commit details
    Browse the repository at this point in the history

  6. Remove bottom-sheet-thumbnail placeholder, clear the image instead

    @Stypox
    Stypox committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    7b9b921 View commit details
    Browse the repository at this point in the history

  7. Improve placeholder thumbnail SVGs and remove theme customization 

    Theme customization does not seem to work well with Picasso: square/picasso#1275
    @Stypox
    Stypox committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    4d58026 View commit details
    Browse the repository at this point in the history

  8. Rename dummy_* and more to placeholder_*

    @Stypox
    Stypox committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    6ea85e6 View commit details
    Browse the repository at this point in the history

  9. Make video and playlist placeholder thumbnails 16:9 

    After making the playlist and video thumbnails' scaleType fitCenter, the 24dp*24dp thumbnails would appear as a square, which would be strange, since the image view is 16:9.
    @Stypox
    Stypox committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    9f993e0 View commit details
    Browse the repository at this point in the history