Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update some misc libraries #8475

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Update some misc libraries #8475

merged 1 commit into from
Jul 18, 2022

Conversation

TacoTheDank
Copy link
Member

@TacoTheDank TacoTheDank commented Jun 2, 2022 •
edited
Loading

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Update Checkstyle 10.0 -> 10.3.1 (changelog)
  • Update AssertJ 3.22.0 -> 3.23.1 (changelog)
  • Update desugar_jdk_libs 1.1.5 -> 1.1.6 (changelog)
  • Update Ktlint 0.44.0 -> 0.45.2 (changelog)
  • Update AndroidX Constraintlayout 2.1.3 -> 2.1.4 (changelog)
  • Update AndroidX Core 1.6.0 -> 1.8.0 (changelog) (please note the new interfaces in the 1.8.0 alphas, they might be useful)
  • Update AndroidX Media 1.5.0 -> 1.6.0 (changelog)
  • Update jsoup 1.14.3 -> 1.15.2 (changelog)
  • Update PrettyTime 5.0.2 -> 5.0.3 (changelog)
  • Update AGP 7.2.0 -> 7.2.1 (changelog)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@triallax triallax added the codequality Improvements to the codebase to improve the code quality label Jun 3, 2022
@triallax
Copy link
Contributor

triallax commented Jun 3, 2022

no available changelog; I diffed the source JARs and it was just two nullability fixes

You can diff the two releases' sources like this: ocpsoft/prettytime@5.0.2.Final...5.0.3.Final

@TacoTheDank
Copy link
Member Author

@mhmdanas I forgot about that. That also works.

@TacoTheDank TacoTheDank force-pushed the bumpMiscLibraries branch 2 times, most recently from ab67378 to 4b2250a Compare July 5, 2022 17:48
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@triallax
Copy link
Contributor

triallax commented Jul 14, 2022 •
edited
Loading

We've some new updates now:

  • ktlint 0.46.1
  • desugar_jdk_libs 1.2.0 (requires AGP 7.3.0-beta03 or later, so we may want to hold off on this)

@TacoTheDank
Copy link
Member Author

@mhmdanas Oh, I'm aware :P

litetex
litetex approved these changes Jul 16, 2022
View reviewed changes
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Stypox Stypox merged commit ae369ec into TeamNewPipe:dev Jul 18, 2022
@Stypox
Copy link
Member

Stypox commented Jul 18, 2022

I tested a little on API 31 and API 22 and couldn't notice anything bad.

please note the new interfaces in the 1.8.0 alphas, they might be useful

Good!

@TacoTheDank TacoTheDank deleted the bumpMiscLibraries branch July 19, 2022 02:25
@Stypox Stypox mentioned this pull request Aug 27, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litetex litetex litetex approved these changes

Assignees
No one assigned
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TacoTheDank @triallax @Stypox @litetex