-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash when rotating device on unsupported channels #8192
Conversation
Reproduction steps:
Also test rotation on a normal channel, the behavior is the same as before. |
app/src/main/java/org/schabi/newpipe/fragments/list/channel/ChannelFragment.java
Show resolved
Hide resolved
Btw, I don't think I am able to test properly. The crash on this channel is actually fixed, but |
Mod note: don't quote if you don't need to. Or quote only the necessary parts. I haven't found the reason yet. I'll try again when I'm free. |
app/src/main/java/org/schabi/newpipe/fragments/list/channel/ChannelFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/fragments/list/channel/ChannelFragment.java
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
I can confirm it works, then. Thank you! #6870 needs to be solved separately, but at least this crash is fixed. Btw, you got PR number 8192=2^13, feel honoured by that ;-) |
The software engineering course of our college requires to contribute to the open source community. |
Great :-D |
What is it?
Description of the changes in your PR
See #6696 (comment)
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence