Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor player and extract UI components #8170

Merged
merged 19 commits into from
Jul 15, 2022
Merged

Refactor player and extract UI components #8170

merged 19 commits into from
Jul 15, 2022

Commits on Jul 13, 2022

  1. Refactor player: separate UIs and more

    @Stypox
    Stypox committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    76ced59 View commit details
    Browse the repository at this point in the history

  2. Fix some crashes / issues after player refactor

    @Stypox
    Stypox committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    b3f9964 View commit details
    Browse the repository at this point in the history

  3. Move all notification-related calls to NotificationPlayerUi

    @Stypox
    Stypox committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    0bba1d9 View commit details
    Browse the repository at this point in the history

  4. Move player-notification files into their package

    @Stypox
    Stypox committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    90a89f8 View commit details
    Browse the repository at this point in the history

  5. Remove unused PlayerState

    @Stypox
    Stypox committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    8c26403 View commit details
    Browse the repository at this point in the history

  6. Remove unused PlayerServiceBinder

    @Stypox
    Stypox committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    6fb0256 View commit details
    Browse the repository at this point in the history

  7. Add comment about broadcast receiver

    @Stypox
    Stypox committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    fa25ecf View commit details
    Browse the repository at this point in the history

  8. Improve //region comments in player UIs

    @Stypox
    Stypox committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    6559416 View commit details
    Browse the repository at this point in the history

  9. Add some javadocs; move preparing player uis to PlayerUiList

    @Stypox
    Stypox committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    1b39b53 View commit details
    Browse the repository at this point in the history

  10. Restore checkstyle and solve its errors

    @Stypox
    Stypox committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    a19073e View commit details
    Browse the repository at this point in the history

  11. Solve some Sonarlint warnings

    @Stypox
    Stypox committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    4979f84 View commit details
    Browse the repository at this point in the history

  12. Fix volume gestures not working anymore

    @Stypox
    Stypox committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    1cf746f View commit details
    Browse the repository at this point in the history

  13. Move functions to get Android dimen to ThemeHelper

    @Stypox
    Stypox committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    9c51fc3 View commit details
    Browse the repository at this point in the history

  14. Move popup layout param to PopupPlayerUi

    @Stypox
    Stypox committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    3692858 View commit details
    Browse the repository at this point in the history

  15. Some refactorings after review comments

    @Stypox
    Stypox committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    61c1da1 View commit details
    Browse the repository at this point in the history

  16. Some SonarLint refactors

    @Stypox
    Stypox committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    c03eac1 View commit details
    Browse the repository at this point in the history

  17. Fix SonarLint java:S5320, restrict broadcasts to app package

    @Stypox
    Stypox committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    4443c90 View commit details
    Browse the repository at this point in the history

  18. Move PlayerType into its own class and add documentation 

    Also replace some `isPlayerOpen` with direct `playerType == null` checks.
    @Stypox
    Stypox committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    8187a3b View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2022

  1. Fix random NullPointerException when adding video player view

    @Stypox
    Stypox committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    0e8cc72 View commit details
    Browse the repository at this point in the history