-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some lint cleaning #8068
Some lint cleaning #8068
Conversation
bc25431
to
102204e
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Task failed successfully I guess. Also there is no retry button xD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
Only minor things I found:
app/src/main/java/org/schabi/newpipe/info_list/dialog/InfoItemDialog.java
Outdated
Show resolved
Hide resolved
97e4b52
to
e9ad44e
Compare
e9ad44e
to
cf213af
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is it?
Description of the changes in your PR
Not annotated parameter overrides @NonNull parameter
lintsAPK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence