Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some lint cleaning #8068

Merged
merged 1 commit into from
Mar 19, 2022
Merged

Some lint cleaning #8068

merged 1 commit into from
Mar 19, 2022

Conversation

TacoTheDank
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Fixed some Not annotated parameter overrides @NonNull parameter lints
  • Deleted a few unused parameters
  • Fixed some other miscellaneous lints regarding Kotlin, unresolved documentation, etc.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@opusforlife2

This comment was marked as off-topic.

@litetex
Copy link
Member

litetex commented Mar 18, 2022

Please retry analysis of this Pull-Request directly on SonarCloud.

grafik

Task failed successfully I guess. Also there is no retry button xD
Rebased the PR, should hopefully work now...

Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

Only minor things I found:

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@triallax triallax added the codequality Improvements to the codebase to improve the code quality label Mar 18, 2022
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@litetex litetex merged commit 6d2b5d9 into TeamNewPipe:dev Mar 19, 2022
@TacoTheDank TacoTheDank deleted the lintCleaning branch March 19, 2022 14:37
@Stypox Stypox mentioned this pull request Apr 16, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants