Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create stub implementation for OnSeekBarChangeListener #8066

Merged
merged 2 commits into from
Mar 19, 2022
Merged

Create stub implementation for OnSeekBarChangeListener #8066

merged 2 commits into from
Mar 19, 2022
+30 −61

Conversation

TacoTheDank
Copy link
Member

@TacoTheDank TacoTheDank commented Mar 18, 2022 •
edited
Loading

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Create a stub implementation of SeekBar.OnSeekBarChangeListener so we can remove unused stuff
  • Utilize the Animator.addListener() KTX extension in SecondsView

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@TacoTheDank TacoTheDank force-pushed the simpleSeekbarChange branch from 1b2067e to 20bddd8 Compare March 18, 2022 02:02
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

litetex
litetex approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@triallax triallax added the codequality Improvements to the codebase to improve the code quality label Mar 18, 2022
@TobiGr TobiGr added the player Issues related to any player (main, popup and background) label Mar 18, 2022
@litetex litetex merged commit 5723138 into TeamNewPipe:dev Mar 19, 2022
@TacoTheDank TacoTheDank deleted the simpleSeekbarChange branch March 19, 2022 14:36
@Stypox Stypox mentioned this pull request Apr 16, 2022
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litetex litetex litetex approved these changes

Assignees
No one assigned
Labels
codequality Improvements to the codebase to improve the code quality player Issues related to any player (main, popup and background)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TacoTheDank @litetex @TobiGr @triallax