Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract view click listeners from Player #8011

Merged
merged 7 commits into from
Mar 16, 2022
Merged

Extract view click listeners from Player #8011

merged 7 commits into from
Mar 16, 2022

Commits on Mar 16, 2022

  1. Extract 2 view click listeners from Player

    @XiangRongLin @litetex
    XiangRongLin authored and litetex committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    080c4ba View commit details
    Browse the repository at this point in the history

  2. delete unused methods

    @XiangRongLin @litetex
    XiangRongLin authored and litetex committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    6a400dd View commit details
    Browse the repository at this point in the history

  3. stupid checkstyle

    @XiangRongLin @litetex
    XiangRongLin authored and litetex committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    d348c20 View commit details
    Browse the repository at this point in the history

  4. Refactored code

    @litetex
    litetex committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    30a8f25 View commit details
    Browse the repository at this point in the history

  5. Made onClick less (cognitive) complex

    @litetex
    litetex committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    ee5e0e1 View commit details
    Browse the repository at this point in the history

  6. Better naming

    @litetex
    litetex committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    cefb524 View commit details
    Browse the repository at this point in the history

  7. Fixed conflicts

    @litetex
    litetex committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    6765135 View commit details
    Browse the repository at this point in the history