Replace R.string.yes with R.string.ok
#7976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android doesn't use yes/no but ok/cancel usually, so this should be done here, too
Stypox
changed the title
R.string.yes with R.string.ok
Stypox
changed the title
R.string.yes with R.string.okR.string.yes with R.string.ok
Stypox
changed the title
R.string.yes with R.string.okR.string.yes with R.string.ok
|
Kudos, SonarCloud Quality Gate passed! |
AudricV
added
the
localisation / translation
litetex
added
the
codequality
|
We could use https://developer.android.com/reference/android/R.string#ok edit: android.R.string.ok is actually "OK". So if lower case is intended it's not usable. |
|
No, we can't for some languages: see the PR linked and #5454. |
|
ok yeah but that was regarding the well known "cancel". But anyway :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android doesn't use yes/no but ok/cancel usually, so this should be done here, too
What is it?
Related info
This can be considered a followup to #7024. I thought all
yeswere replaced byokin that PR, but apparently it was not the case (as I could notice in #5878), hence this PR.APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence