Replace CircleImageView with ShapeableImageView #7925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AudricV
reviewed
Feb 22, 2022
app/src/main/java/org/schabi/newpipe/fragments/list/playlist/PlaylistFragment.java
Outdated
Show resolved
Hide resolved
litetex
reviewed
Feb 22, 2022
app/src/main/java/org/schabi/newpipe/fragments/list/playlist/PlaylistFragment.java
Outdated
Show resolved
Hide resolved
TacoTheDank
force-pushed
the
removeCircleImageView
branch
from
386e130 to
e60fc94
Compare
TacoTheDank
force-pushed
the
removeCircleImageView
branch
from
e60fc94 to
1a000fe
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Stypox
approved these changes
Feb 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
The CircleImageView library repository hasn't been touched in over a year (though I guess that doesn't matter much). ImageView transformation exists now in Google Material anyway, so the library is no longer necessary.
Before/After Screenshots/Screen Record
Not necessary. Although the margins and padding worked pretty differently between the two ImageView implementations (requiring quite a bit of adjustments), I matched the previous behavior as precisely as possible by using exact margins, adding some tiny padding where necessary, and other such things. I actually dare you to try and find a noticeable difference :) I DARE YOU-
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence