Remember adjustment step size for playback controls (speed and pitch)

[ktprograms]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Save adjustmentStepSize to shared preferences, pass it back and forth
  between PlaybackParameterDialog and Player/PlayQueueActivity.
• Made DEFAULT_STEP in PlaybackParameterDialog public so it can be used as
  the default adjustmentStepSize value in the Player.

Before/After Screenshots/Screen Record

Before	After
before.mp4	after.mp4

Fixes the following issue(s)

• Fixes Remember step for playback speed controls #7031

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

• I read the contribution guidelines.

[Stypox]

I don't think you should pass around the adjustmentStepSize as a playback parameter. It's not something influencing the playback, it's just a value to save to / read from preferences. You should just read it when the PlaybackParameterDialog is setup, and save it when the user changes it inside the same dialog.

[ktprograms]

@Stypox Sorry, I was busy so I didn't have time to look at the code.

I'm guessing this should be done similarly to how setupHookingControl handles accessing the preferences?

NewPipe/app/src/main/java/org/schabi/newpipe/player/helper/PlaybackParameterDialog.java

Lines 237 to 260 in af80d96

	private void setupHookingControl(@NonNull final View rootView) {
	unhookingCheckbox = rootView.findViewById(R.id.unhookCheckbox);
	if (unhookingCheckbox != null) {
	// restore whether pitch and tempo are unhooked or not
	unhookingCheckbox.setChecked(PreferenceManager
	.getDefaultSharedPreferences(requireContext())
	.getBoolean(getString(R.string.playback_unhook_key), true));
	unhookingCheckbox.setOnCheckedChangeListener((compoundButton, isChecked) -> {
	// save whether pitch and tempo are unhooked or not
	PreferenceManager.getDefaultSharedPreferences(requireContext())
	.edit()
	.putBoolean(getString(R.string.playback_unhook_key), isChecked)
	.apply();
	if (!isChecked) {
	// when unchecked, slide back to the minimum of current tempo or pitch
	final double minimum = Math.min(getCurrentPitch(), getCurrentTempo());
	setSliders(minimum);
	setCurrentPlaybackParameters();
	}
	});
	}
	}

[Stypox]

@ktprograms yes, I think that's the way to go

[ktprograms]

@Stypox Since the step size will now be saved to shared preferences, should I remove the code that saves it to/reads it from outState?

[Stypox]

@ktprograms yes, there is no need to save/restore it there

[ktprograms]

@Stypox Done, basically rewrote the entire commit, so here's the overview of everything changed:

• Add adjustment_step_key to settings_keys.xml to be used when
  saving/loading the step size.
• Remove the global stepSize variable and the code that saves it to
  outState/loads it from savedInstanceState because it's now saved to
  Shared Preferences.
• Move initially setting step size to setupStepSizeSelector to be
  consistent with the other view setup methods, using the value loaded
  from Shared Preferences.
• Save the step size to Shared Preferences inside setStepSize.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[Stypox]

Thank you! Code looks good to me, I'm going to test it later :-)

[Stypox]

I tested and everything seems to work well :-)

[ktprograms]

Thanks!