implement ability to ignore back-queue for main view #7273
Conversation
|
This should probably beeing closed in favor of #6895 |
no i think this good idea... i would like to go back through the queue using the back button, however by implementing your idea, i gain the ability to minimize the player after queue is completed which is the behavior i prefer at this point. so yes I think both PRs should be implemented as everyone of them has its unique usages |
|
Agree |
triallax
added
feature request
|
The functionality in this PR is already available in #6895. It is basically a duplicate. |
|
@Stypox yep, this functionality is already available in my PR, nothing to add |
|
Can this be made default for Android TV? |
I guess |
|
I made it default for tv's. However, displaying the correct state in the settings is really not that great, but i dont see any other way to do it. |
# Conflicts: # app/src/main/java/org/schabi/newpipe/settings/HistorySettingsFragment.java # app/src/main/res/values/strings.xml
|
@opusforlife2 @Stypox Any news on this? It's a rather simple PR and would add a highly requested feature. |
|
@newhinton I like the idea. We need for someone to have the time to review this. Meanwhile, please fix any merge conflicts. |
|
I have resolved the conflict. |
|
This would be really useful for navigating TVs, do you have a debug apk? |
|
@bazipn I build one. |
|
Kudos, SonarCloud Quality Gate passed! |
|
Is this still active or not? This functionality is important to me on both my TV and phone UI, as well as many other people evident from looking at the issues about this. |
There was a problem hiding this comment.
Sorry for not reviewing earlier, I did start a review but never sent it 🤦
Closing as this is tricky to get right, as the comments I left highlight. We'll decide on a more user-friendly UI/UX for the player pages during the rewrite, and we'll definitely ditch the current strange behavior in favour of what most people would expect. We've not been able to do that so far, also because of how bad the code is.
| @@ -782,6 +789,11 @@ public boolean onBackPressed() { | |||
| return true; | |||
| } | |||
|
|
|||
| // when queue should be ignored, directly skip checks and let MainActivity handle everything | |||
| if (ignoreQueue) { | |||
| return false; | |||
There was a problem hiding this comment.
I think you should also restoreDefaultOrientation()
| ignoreQueue = prefs.getBoolean( | ||
| getString(R.string.enable_ignore_backstack_key), | ||
| DeviceUtils.isTv(activity) | ||
| ); |
There was a problem hiding this comment.
What if the user changes preference while the fragment is open? You need to update this variable in the shared preference change listener.
|
|
||
| private boolean ignoreQueue; | ||
|
|
There was a problem hiding this comment.
Rename the variable and remove spaces
| private boolean ignoreQueue; | |
| private boolean ignoreBackstack; |
What is it?
Description of the changes in your PR
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence