-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Show Channel Details where it's missing #6919
Merged
Stypox
merged 16 commits into
TeamNewPipe:dev
from
ktprograms:channel-details-all-places
Aug 24, 2021
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
759a078
Add uploader_url column to StreamEntity
ktprograms c248741
Add Show Channel Details to Subscription Feed & History
ktprograms 76803bf
Save channelUrl to Database if it doesn't exist
ktprograms d8888e3
Catch error from ExtractorHelper.getStreamInfo, remove blockingGet
ktprograms 241054f
Remove hardcoded string
ktprograms bd0427c
Refactor duplicated code into method
ktprograms 21bcade
Make uploader_url column nullable
ktprograms 65f2730
Add comment about xerial sqlite workaround
ktprograms 85fbd25
Fix typo in app/build.gradle
ktprograms 6f1958d
Remove setting uploaderUrl to empty string if null
ktprograms 712985c
Save uploader url when adding from PlayQueueItem
ktprograms 02aa6fc
Remove v2 to v3 migration test, add v3 to v4 test
ktprograms 967bdf8
Remove migration test, add manual testing reminder to Migrations.java
ktprograms a209e87
Add Loading Channel Details Toast
ktprograms 2928df0
Fix checkstyle ParenPad error
ktprograms 7e27e73
Remove xerial sqlite dependency
ktprograms File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
713 changes: 713 additions & 0 deletions
713
app/schemas/org.schabi.newpipe.database.AppDatabase/4.json
Large diffs are not rendered by default.
Oops, something went wrong.
134 changes: 0 additions & 134 deletions
134
app/src/androidTest/java/org/schabi/newpipe/database/AppDatabaseTest.kt
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thank you :-)