Show hearts in comments

[KalleStruik]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Show a heart next to the like count on comments that have heartedByUploader set to true.

Before/After Screenshots/Screen Record

• Before:
  

• After:
  

Fixes the following issue(s)

• Fixes Show hearts in comments #6458

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

• I read the contribution guidelines.

[skyGtm]

It would be better if Heart color was RED.

[Stypox]

Thank you! :-)
Please test on Android 4.4 and check if the heart shows up

[KalleStruik]

I applied the changes requested. Also changed the heart color to be red as suggested by skyGtm. The below screenshot shows the red hearts working on android 4.4

[opusforlife2]

Do we need a hover text on the icon saying "Liked by uploader"?

[SameenAhnaf]

@opusforlife2 Personally, I don't think so. We have two alternatives instead.

1. Show uploader icon on the right bottom corner of the heart (just like in YouTube app)
2. A toast like 'Liked by uploader' may appear when short pressed on the 'Heart' icon. (I like this as the UI will remain clean. Also, the user might be curious about the function of heart.)

[Stypox]

@SameenAhnaf the second one is bad ui; the first one could be a good idea but idk if it would be simple to implement

[KalleStruik]

I added the avatar to see how it would look. What do you all think about something like this?
Currently using the comment author's avatar because I have not yet found a way to get the video uploader avatar. Any help with how to do that would be appreciated.

[skyGtm]

Instead of showing hearts in channel avatar,
What about replacing existing thumb-up icon with:

I prefer 2nd or 4th picture

[SameenAhnaf]

@skyGtm Like and Love are completely two different actions. We should not just focus on aesthetics rather on logic as well. That way, other users won't get confused.

@KalleStruik I'd personally prefer layout in #6741 (comment) over the latest layout. I'm not sure if the latest layout will pave the way for other devs to replace uploader icon there. If that's the case, I'm completely fine with it.

[KalleStruik]

@SameenAhnaf Currently I have not pushed the changes made in #6741 (comment) onto this branch yet, because I have not found a way to use the video uploader avatar instead of the commenter avatar. I was hoping someone else reading this PR would know of a way to get it, since I do not see an obvious way to do so.

[Stypox]

Any help with how to do that would be appreciated.

@KalleStruik I think this is not doable unfortunately, after looking into it. The comments themselves know nothing about the uploader avatar, and obtaining that info from the video detail fragment is not doable either, since comments could finish loading before video info does, so the uploader avatar url would not be available. So let's stick to just the heart with the tooltip; ignore my review above.

[Stypox]

Almost ready ;-)

[KalleStruik]

I made the changes you requested, but I seem to be getting hit by #6744 now, so I can't test it.

[Stypox]

Code looks good. I couldn't test on YouTube either (though at least in SoundCloud and PeerTube it doesn't crash), let's wait until that problem is solved. Thank you!

[Stypox]

It works, I finally tested by using by opening this fork by @FireMasterK with fixed comments, except that they are not completely fixed so the "heartedByUploader" part was wrong, but I was able to test anyway by debugging and manually setting CommentsInfoItem.heartedByUploader = true for some items. I tested both on API 30 and API 19. Thank you!

[castrik]

I personally prefer how the youtube app does this, they show the avatar of the uploader as the icon with a small heart beside it

[tsiflimagas]

@castrik as it was discussed in the above messages, that's not feasible in newpipe.

[castrik]

I think stypox said comments don't know about the commentor's avatar as the ss posted by kalle struik does that, youtube app has the video uploader's avatar in the heart
is that not possible either? or was he saying this exact thing?

[Stypox]

I think stypox said comments don't know about the commentor's avatar

No, obviously comments do know about the commentor's avatar, otherwise how would they be able to display it?

youtube app has the video uploader's avatar in the heart

Yes, but doing this would require many YouTube-only strange changes in the extractor, and I don't think it's worth it for such a little design improvement.

[FireMasterK]

Yes, but doing this would require many YouTube-only strange changes in the extractor, and I don't think it's worth it for such a little design improvement.

I think this can be avoided by getting the channel avatar from the StreamInfo object itself.

[Stypox]

@FireMasterK that can't be done since comments can load before the stream info. I would not pospone loading comments just for a style improvement