Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert AudioReactor to Kotlin. #6657

Conversation

Isira-Seneviratne
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Convert the AudioReactor class to Kotlin.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@TacoTheDank
Copy link
Member

Can you combine these two commits into one? It'd probably be cleaner.

@Isira-Seneviratne
Copy link
Member Author

The first commit was produced by Android Studio, and it makes changes easier to identify: c29b3be

@Redirion
Copy link
Member

can you move the companion object to the top of the class? I personally prefer to have constants and class variables next to each other like in Java. You need to scroll down the whole file to find them.

@TacoTheDank
Copy link
Member

TacoTheDank commented Jul 17, 2021

can you move the companion object to the top of the class? I personally prefer to have constants and class variables next to each other like in Java. You need to scroll down the whole file to find them.

As far as I can tell, Kotlin's coding conventions guide seems to suggest that companion objects would be best kept at the bottom of a class. Would it be better to adhere as closely as possible to Kotlin's official coding conventions for the sake of less confusion?

@triallax
Copy link
Contributor

I believe this PR goes against #6659?

@Isira-Seneviratne
Copy link
Member Author

I believe this PR goes against #6659?

Okay, I'll close this.

@Isira-Seneviratne Isira-Seneviratne deleted the Convert_AudioReactor_to_Kotlin branch July 18, 2021 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants