Fix crash when using Repeat Button in tablet layout #6622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiGr
changed the title
TobiGr
added
bug
Closed
See #6577 (comment) java.lang.ClassCastException: android.widget.ImageButton cannot be cast to androidx.appcompat.widget.AppCompatImageButton at org.schabi.newpipe.player.Player.onRepeatModeChanged(Player.java:2263) at com.google.android.exoplayer2.ExoPlayerImpl.lambda$setRepeatMode$2(ExoPlayerImpl.java:564) at com.google.android.exoplayer2.-$$Lambda$ExoPlayerImpl$rgrcbaqP9Y8LgzdByBnAfUO4ydU.invokeListener(lambda) at com.google.android.exoplayer2.BasePlayer$ListenerHolder.invoke(BasePlayer.java:279) at com.google.android.exoplayer2.ExoPlayerImpl.invokeAll(ExoPlayerImpl.java:1498) at com.google.android.exoplayer2.ExoPlayerImpl.lambda$notifyListeners$6(ExoPlayerImpl.java:1318) at com.google.android.exoplayer2.-$$Lambda$ExoPlayerImpl$b59raXxaB-trjwE5bgpZInm1QnU.run(lambda) at com.google.android.exoplayer2.ExoPlayerImpl.notifyListeners(ExoPlayerImpl.java:1328) at com.google.android.exoplayer2.ExoPlayerImpl.notifyListeners(ExoPlayerImpl.java:1318) at com.google.android.exoplayer2.ExoPlayerImpl.setRepeatMode(ExoPlayerImpl.java:564) at com.google.android.exoplayer2.SimpleExoPlayer.setRepeatMode(SimpleExoPlayer.java:1636) at org.schabi.newpipe.player.Player.setRepeatMode(Player.java:2253) at org.schabi.newpipe.player.Player.onRepeatClicked(Player.java:2232) at org.schabi.newpipe.player.Player.onBroadcastReceived(Player.java:1123) at org.schabi.newpipe.player.Player.access$200(Player.java:190) at org.schabi.newpipe.player.Player$3.onReceive(Player.java:1060) at android.app.LoadedApk$ReceiverDispatcher$Args.run(LoadedApk.java:1185) ... 7 more
TobiGr
force-pushed
the
fix/RepeatModeChange
branch
from
6d7c671 to
de312eb
Compare
|
Where is the apk?? |
|
Ok thanks. Aaaaaaand it works |
Stypox
approved these changes
Jul 8, 2021
opusforlife2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Fixes ClassCastException when using the repeatButton with the tablet layout
Fixes the following issue(s)
APK testing
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
Due diligence