Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.21.6 #6576

Merged
merged 146 commits into from
Jul 12, 2021
Merged
Changes from 1 commit
Commits
Show all changes
146 commits
Select commit Hold shift + click to select a range
a3c4a10
Convert the abstract class DAOs to interfaces.
Isira-Seneviratne Jan 20, 2021
cd0a877
Update Room to 2.3.0.
Isira-Seneviratne May 16, 2021
e8b8391
Rename .java to .kt
Isira-Seneviratne May 16, 2021
3b1c4b0
Convert Converters to a Kotlin object.
Isira-Seneviratne May 16, 2021
96d731d
Refactor equals method
imericxu May 22, 2021
01aab25
Add Tab.hashCode() to go with equals
imericxu May 22, 2021
1cac389
Refactor KioskTab.equals
imericxu May 22, 2021
d2b03af
Add KioskTab.hashCode() matching equals
imericxu May 22, 2021
14bbacc
Refactor ChannelTab.equals
imericxu May 22, 2021
1812249
Add ChannelTab.hashCode() matching equals
imericxu May 22, 2021
2fc26bc
Refactor PlaylistTab.equals
imericxu May 22, 2021
448989f
Add PlaylistTab.hashCode() matching equals
imericxu May 22, 2021
a102fc9
Use constraint layout for play queue item
Stypox Jun 7, 2021
3b00459
Increase buffer for playback after rebuffer
Redirion Jun 7, 2021
761e01c
Merge pull request #6443 from Stypox/invalid-attr
TobiGr Jun 8, 2021
6ad4b42
Better error handling of terminated channels when loading feed
TobiGr Apr 2, 2021
ccc4697
Show detailed error message when an account has been terminated by th…
TobiGr Mar 31, 2021
c5dd3dc
Improve error message when loading feed
TobiGr Mar 31, 2021
89317d4
Fix feed loading and show a dialog for each invalid subscription
Stypox Apr 2, 2021
b57ecae
Fix getting error cause
TobiGr Apr 2, 2021
7c78d96
Translated using Weblate (Indonesian)
weblate Jun 8, 2021
1e09a17
Revert all commits related to ContentSettingsFragment
Stypox Jun 5, 2021
0f75024
Support SAF properly
wb9688 Jun 13, 2020
1164ea5
Move Stored(File|Directory)Helper into NewPipe
wb9688 Jun 14, 2020
cb4e615
Use file picker for export DB
wb9688 Jun 15, 2020
febb21a
Fix non-SAF actions
wb9688 Jul 30, 2020
7efe62e
Only ask for storage permissions when not using SAF
wb9688 Aug 2, 2020
1e8b382
Add setting migration to promote using SAF
Stypox Jan 14, 2021
6a0c5a8
Fix ContentSettingsManager tests
Stypox Jan 14, 2021
bcb1cf6
Improve SAF switch descriptions in settings
Stypox Jan 16, 2021
eea43d5
Add comments to SharpStreams
Stypox Jan 16, 2021
114dc8f
Pass mime type so that SAF treats file extension correctly
Stypox Jan 16, 2021
b78ac7d
Fix strange behaviour when app loses access to saf download folder
Stypox Jan 16, 2021
21b8df0
Check if file really exists before asking user to overwrite it
Stypox Mar 17, 2021
5ffc667
Remove misplaced comment
Stypox Mar 17, 2021
2a99e0e
Reimplement storing backup import/export path
Stypox Jun 6, 2021
c96bdfc
Merge pull request #5415 from Stypox/saf
TobiGr Jun 8, 2021
f63a4ee
Merge pull request #5876 from TeamNewPipe/terminated-channels
TobiGr Jun 8, 2021
3dc4ed1
Add "Open website" button in webview in license fragment, issue #6296
Peyman-hme May 16, 2021
e0c1ca1
Change "Ok" Button to "Dismiss" and also change "Open Website" button…
Peyman-hme May 19, 2021
6fc0d8f
Add Open website string resources
Peyman-hme May 19, 2021
5e2735a
Merge pull request #5462 from Isira-Seneviratne/Convert_abstract_clas…
Stypox Jun 8, 2021
63cff25
Merge pull request #6314 from Peyman-hme/Add-Open-website-button-to-w…
Stypox Jun 8, 2021
5532666
Long press on player share button to copy url to clipboard
Jun 5, 2021
bede758
Use url at current time for long click on player share button
Stypox Jun 8, 2021
0b64382
Merge pull request #6436 from Abanoub8/add_url_button
Stypox Jun 8, 2021
543440e
Update app/src/main/java/org/schabi/newpipe/settings/tabs/Tab.java
Stypox Jun 8, 2021
a2fd5ae
Update app/src/main/java/org/schabi/newpipe/settings/tabs/Tab.java
Stypox Jun 8, 2021
a2eead5
Merge pull request #6346 from Imericxu/tabs-style-check
Stypox Jun 8, 2021
56cd84c
Merge pull request #6444 from TeamNewPipe/increasebufferafterdepletion
TobiGr Jun 8, 2021
e846f69
Add ability to hide played items in a feed
mauriciocolli Apr 5, 2020
360f5ac
Save playback state even if stream is finished and add isFinished()
Stypox Mar 26, 2021
e58fead
Remove IN HISTORY label on stream info items
Stypox Mar 26, 2021
0113ad5
Correctly save stream progress at the end of a video
Stypox Jun 7, 2021
06d10cf
Merge pull request #6313 from Isira-Seneviratne/Update_Room_to_2.3.0
Stypox Jun 9, 2021
9591f14
Update AndroidX Fragment to 1.3.4
TacoTheDank Jun 10, 2021
4031777
Open recognized timestamps in the description of contents in the popu…
AudricV Feb 1, 2021
ae9349e
Initial work: add support for opening timestamps in plain text descri…
AudricV Mar 13, 2021
9e9d1a0
Fix toast shown when falling back to Google Play Store URL and the ac…
AudricV Mar 13, 2021
6abdd2a
Try to change message of the system chooser for the update notification
AudricV Mar 13, 2021
c972940
Apply suggested changes and fix some warnings
AudricV Mar 18, 2021
2fb8636
Fix title of the subject when sharing an URL
AudricV Mar 18, 2021
d85afd6
Initial work to add the image of the content in the share sheet
AudricV Mar 20, 2021
d6decc0
Move some classes to a new subpackage and adress requested changes
AudricV Mar 26, 2021
e5df2f6
Move some classes to a new subpackage and adress requested changes
AudricV Mar 26, 2021
267686f
Initial work: add support for opening hashtags in plain text descript…
AudricV Mar 27, 2021
2702700
Don't use a chooser for other intents than opening a content in a bro…
AudricV Apr 2, 2021
a79badd
Adress requested changes and try some cleanup in handleUrl method of …
AudricV Apr 3, 2021
f13f4cc
Split handleUrl method into two methods
AudricV Apr 3, 2021
da4d379
Initial work: use disposables for timestamps parsing in YouTube video…
AudricV Apr 4, 2021
f02df6d
Fix an error and add a new method in the ShareUtils class
AudricV Apr 25, 2021
218f25c
Annotate params and methods with NonNull
AudricV May 21, 2021
eef418a
Improve text linkifier function parameters
Stypox Jun 5, 2021
edfe0f9
Fix disposables handling for text linkifier
Stypox Jun 5, 2021
32b0bdb
Fix the compile error
AudricV Jun 11, 2021
4eef498
Only call addClickListenersOnTimestamps if relatedInfo is instance of…
AudricV Jun 11, 2021
8c52a81
Added itemsListHeaderDuration to large-hand player
litetex Jun 11, 2021
547a1a9
Merge pull request #6480 from litetex/fixMissingitemsListHeaderDuration
TobiGr Jun 12, 2021
6063ff0
CONTRIBUTING.md: add "Build instructions" section and improve ordering
Stypox Jun 13, 2021
2142f05
Fix hiding finished streams in groups; new stream state validity cond…
Stypox Jun 7, 2021
4698d07
Do not hide feed buttons (show/hide & help) behind three-dots menu
Stypox Jun 9, 2021
7145b11
Fix long press menu in feed
Stypox Jun 9, 2021
fdb6679
Make list stream item ConstraintLayouts and use chain
Stypox Jun 14, 2021
32df4d3
Reshow feed if grid/list view mode changed
Stypox Jun 15, 2021
92910eb
Merge pull request #5523 from TiA4f8R/share-improvements
Stypox Jun 15, 2021
e01ef42
Adds manual tablet mode setting
Dakkaron Apr 11, 2021
d6e0bd8
Merge pull request #6059 from Dakkaron/manual-tablet-mode-setting
Stypox Jun 15, 2021
e4885e3
Fix some older deprecations from previous Fragment versions
TacoTheDank Jun 16, 2021
1061fca
Add super.onRequestPermissionsResult where missing
TacoTheDank Jun 16, 2021
aa4e5da
Fix onActivityResult deprecation in ContentSettingsFragment
TacoTheDank Jun 16, 2021
cae160b
Fix onActivityResult deprecation in SubscriptionsImportFragment
TacoTheDank Jun 16, 2021
a1432e9
Fix onActivityResult deprecation in SubscriptionFragment
TacoTheDank Jun 16, 2021
a9ab2f5
dismiss choice dialog in onStop() to avoid a leaked window Exception:
evermind-zz May 25, 2021
2de9d7b
Merge branch 'master' into dev
TobiGr Jun 17, 2021
90de759
Replaced System.Exit calls with FinishAffinity and Start Activity calls
danielmbutler Jun 15, 2021
8b3e32b
First round of review
Stypox Jun 17, 2021
841fb4c
Merge pull request #6495 from danielmbutler/Replace-System.exit-calls
Stypox Jun 17, 2021
0803d9f
Merge pull request #6504 from evermind-zz/fixes-choice-dialog
Redirion Jun 17, 2021
be676ad
Merge pull request #3371 from mauriciocolli/feed-hide-played-items
TobiGr Jun 18, 2021
6e377dd
Translated using Weblate (Serbian)
TobiGr Jun 18, 2021
0db3406
Fix SonarLint references and explanation
Stypox Jun 18, 2021
74ad488
Merge pull request #6394 from TacoTheDank/androidx-fragment-134
Stypox Jun 18, 2021
79deff3
Annotate some overridden methods and parameters as NonNull
TacoTheDank Jun 19, 2021
6c57551
Merge pull request #6528 from TacoTheDank/annotate-methods
B0pol Jun 20, 2021
62b4f33
Don't enable SAF on Fire TV (#6516)
triallax Jun 20, 2021
a9e85ab
Ask for screenshots/video of UI changes
opusforlife2 Jun 20, 2021
46bfec6
Localization: Fix Simplified Chinese Plural
chr56 May 16, 2021
384ca66
#6522: Fix null pointer exception when displaying SearchFragment
Douile Jun 22, 2021
25cf8dc
Refactoring by Android Studio
B0pol Jun 23, 2021
484c852
Merge pull request #6556 from B0pol/kotlin-style
AudricV Jun 23, 2021
5ebf372
Comment out test-android CI job
XiangRongLin Jun 23, 2021
b996fa7
Add comments explaining decisions in test-android ci job
XiangRongLin Jun 23, 2021
63cad7e
Merge pull request #6562 from TeamNewPipe/disable_instrumented_ci
B0pol Jun 24, 2021
65824ff
Update Invidious instances
B0pol Jun 23, 2021
d7dcfa5
Update Extractor version
B0pol Jun 23, 2021
0da8e28
Merge pull request #6558 from Douile/fix/searchfragment-null-service
B0pol Jun 24, 2021
25914b0
Third round of review
Stypox Jun 24, 2021
78a9952
Merge pull request #6557 from B0pol/invidious-instances
AudricV Jun 24, 2021
ec40c8e
Merge pull request #6482 from Stypox/build-instructions
opusforlife2 Jun 24, 2021
090c063
Address Bopol's review
opusforlife2 Jun 24, 2021
c398308
Merge pull request #6539 from TeamNewPipe/screenshots_for_UI_changes
B0pol Jun 24, 2021
201e5ee
Fix NPE when connecting via BT
Jun 25, 2021
33fbc88
Translated using Weblate (Polish)
weblate Jun 26, 2021
99335ba
Add changelog for 0.21.6 (972)
TobiGr Jun 26, 2021
23f6e10
Add question template
triallax Jul 1, 2021
83b198f
Merge pull request #6570 from Redirion/fixnpe
TobiGr Jul 3, 2021
a63683e
Update extractor version
TobiGr Jul 4, 2021
e26607f
Translated using Weblate (Bengali)
weblate Jul 4, 2021
3931c0d
Merge pull request #6545 from chr56/fix_zh
TobiGr Jul 4, 2021
d8a0a74
Allow asking multiple questions at once
triallax Jul 5, 2021
5ac418a
Merge pull request #6593 from mhmdanas/add-question-template
opusforlife2 Jul 6, 2021
09435a1
Update bug_report.md
litetex Jul 6, 2021
29aa1de
Merge pull request #6617 from litetex/improve-wording-in-bug-report
Stypox Jul 7, 2021
de312eb
Fix ClassCastException
TobiGr Jul 8, 2021
a94dacf
Merge pull request #6622 from TeamNewPipe/fix/RepeatModeChange
TobiGr Jul 8, 2021
82cdb0f
Translated using Weblate (Ukrainian)
weblate Jul 9, 2021
bb386fe
Remove unused translations of "downloads_storage_ask_summary_kitkat"
TobiGr Jul 9, 2021
4ea2d8e
Removed translations with incorrect number of arguments for formatting
TobiGr Jul 9, 2021
a73a4af
Fix APK testing section (#6623)
TobiGr Jul 9, 2021
7c3f5a6
Fix crash when refreshing feed after importing database or subscriptions
TobiGr Jul 10, 2021
9ca2691
Add close() method to NewPipeDatabase
TobiGr Jul 10, 2021
ab838fd
Merge pull request #6639 from TeamNewPipe/fix/db_transaction
TobiGr Jul 10, 2021
fd3d46c
Translated using Weblate (Polish)
weblate Jul 10, 2021
3a83062
Translated using Weblate (Polish)
weblate Jul 12, 2021
4e9631a
Update extractor version to 0.21.6
TobiGr Jul 10, 2021
1e46864
Release 0.21.6 (972)
TobiGr Jun 26, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix onActivityResult deprecation in SubscriptionFragment
  • Loading branch information
TacoTheDank committed Jun 16, 2021
commit a1432e939f417eca4ce633b35ecebc41848c0396
Original file line number Diff line number Diff line change
@@ -15,6 +15,8 @@ import android.view.MenuInflater
import android.view.View
import android.view.ViewGroup
import android.widget.Toast
import androidx.activity.result.ActivityResult
import androidx.activity.result.contract.ActivityResultContracts.StartActivityForResult
import androidx.appcompat.app.AlertDialog
import androidx.lifecycle.ViewModelProvider
import androidx.localbroadcastmanager.content.LocalBroadcastManager
@@ -82,6 +84,11 @@ class SubscriptionFragment : BaseStateFragment<SubscriptionState>() {
private lateinit var feedGroupsSortMenuItem: HeaderWithMenuItem
private val subscriptionsSection = Section()

private val requestExportLauncher =
registerForActivityResult(StartActivityForResult(), this::requestExportResult)
private val requestImportLauncher =
registerForActivityResult(StartActivityForResult(), this::requestImportResult)

@State
@JvmField
var itemsListState: Parcelable? = null
@@ -184,39 +191,39 @@ class SubscriptionFragment : BaseStateFragment<SubscriptionState>() {
}

private fun onImportPreviousSelected() {
startActivityForResult(StoredFileHelper.getPicker(activity), REQUEST_IMPORT_CODE)
requestImportLauncher.launch(StoredFileHelper.getPicker(activity))
}

private fun onExportSelected() {
val date = SimpleDateFormat("yyyyMMddHHmm", Locale.ENGLISH).format(Date())
val exportName = "newpipe_subscriptions_$date.json"

startActivityForResult(
StoredFileHelper.getNewPicker(activity, exportName, "application/json", null),
REQUEST_EXPORT_CODE
requestExportLauncher.launch(
StoredFileHelper.getNewPicker(activity, exportName, "application/json", null)
)
}

private fun openReorderDialog() {
FeedGroupReorderDialog().show(parentFragmentManager, null)
}

override fun onActivityResult(requestCode: Int, resultCode: Int, data: Intent?) {
super.onActivityResult(requestCode, resultCode, data)
if (data != null && data.data != null && resultCode == Activity.RESULT_OK) {
if (requestCode == REQUEST_EXPORT_CODE) {
activity.startService(
Intent(activity, SubscriptionsExportService::class.java)
.putExtra(SubscriptionsExportService.KEY_FILE_PATH, data.data)
)
} else if (requestCode == REQUEST_IMPORT_CODE) {
ImportConfirmationDialog.show(
this,
Intent(activity, SubscriptionsImportService::class.java)
.putExtra(KEY_MODE, PREVIOUS_EXPORT_MODE)
.putExtra(KEY_VALUE, data.data)
)
}
fun requestExportResult(result: ActivityResult) {
if (result.data != null && result.resultCode == Activity.RESULT_OK) {
activity.startService(
Intent(activity, SubscriptionsExportService::class.java)
.putExtra(SubscriptionsExportService.KEY_FILE_PATH, result.data?.data)
)
}
}

fun requestImportResult(result: ActivityResult) {
if (result.data != null && result.resultCode == Activity.RESULT_OK) {
ImportConfirmationDialog.show(
this,
Intent(activity, SubscriptionsImportService::class.java)
.putExtra(KEY_MODE, PREVIOUS_EXPORT_MODE)
.putExtra(KEY_VALUE, result.data?.data)
)
}
}

@@ -436,9 +443,4 @@ class SubscriptionFragment : BaseStateFragment<SubscriptionState>() {
val minWidth = resources.getDimensionPixelSize(R.dimen.channel_item_grid_min_width)
return max(1, floor(resources.displayMetrics.widthPixels / minWidth.toDouble()).toInt())
}

companion object {
private const val REQUEST_EXPORT_CODE = 666
private const val REQUEST_IMPORT_CODE = 667
}
}