Commits on Jul 6, 2021

1. Prevent error msg: 'Unrecoverable player error occurred' while playin… …

   …g video during rotation (TeamNewPipe#6502)
   
   Playing a video in VideoDetailFragment and rotating the screen to landscape (back and forth more often)
   can trigger this error message. Especially if rotation for whatever reason takes long or
   playing a high resolution (1080p) video.
   
   The underlying logcat error messages:
   05-12 16:38:38.251 24920 26037 E Surface : getSlotFromBufferLocked: unknown buffer: 0x923fc810
   05-12 16:38:38.251 24920 26037 W ACodec  : [OMX.qcom.video.decoder.avc] can not return buffer 35 to native window
   
   The problem is that that Exoplayer is trying to write to our -- during rotation -- no longer existant
   (VideoDetailFragment) SurfaceView.
   
   Solution:
   Implementing SurfaceHolder.Callback and using DummySurface we can now handle the lifecycle of the Surface.
   
   How?: In case we are no longer able to write to the Surface eg. through rotation/putting in
   background we can set a DummySurface. Although it only works on API >= 23.
   Result: we get a little video interruption (audio is still fine) but we won't get the
   'Unrecoverable player error occurred' error message.
   
   This implementation is based on and more background information:
    'ExoPlayer stuck in buffering after re-adding the surface view a few time 2703'
   
    -> exoplayer fix suggestion link
     google/ExoPlayer#2703 (comment)

   

   evermind-zz committed Jul 6, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for f78d2a5
   • Browse repository at this point

   Copy the full SHA

   f78d2a5 View commit details

   Browse the repository at this point in the history