Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build instructions #6482

Merged
merged 4 commits into from
Jun 24, 2021
Merged

Build instructions #6482

merged 4 commits into from
Jun 24, 2021

Conversation

Stypox
Copy link
Member

@Stypox Stypox commented Jun 13, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

This PR adds a "Build instructions" section to the .github/CONTRIBUTING.md file with Android Studio, checkStyle and ktlint setup. It also improves the rest of the file by adding more subtitles, changing the order of points and highlighting important words with bold. I added a link to the Element Matrix client, too. What do you think @TobiGr @B0pol @XiangRongLin @opusforlife2 @mhmdanas @litetex?

Fixes the following issue(s)

Fixes #6220

Due diligence

Copy link
Member

@B0pol B0pol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about commandline?

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
One small thing: when using full sentences in the bullet list, they should end with a full stop

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
@TobiGr TobiGr added the meta Related to the project but not strictly to code label Jun 13, 2021
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
@Stypox
Copy link
Member Author

Stypox commented Jun 17, 2021

I addressed all reviews

"(or use your fork)"
Do you mean "Use the Fork button"?

Why can't I answer? Anyway, I meant "or use use the link from your own fork, if you then want to open a PR". I updated it.

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
@Stypox
Copy link
Member Author

Stypox commented Jun 18, 2021

Is this ok @litetex ?

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
@litetex
Copy link
Member

litetex commented Jun 19, 2021

@Stypox

Is this ok @litetex ?

I'm fine with them 😄

@Stypox
Copy link
Member Author

Stypox commented Jun 24, 2021

@opusforlife2 done, it is ok now? Please merge if that's the case

@opusforlife2 opusforlife2 merged commit ec40c8e into TeamNewPipe:dev Jun 24, 2021
@Stypox Stypox deleted the build-instructions branch July 5, 2021 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to the project but not strictly to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contribution: Add a guide that explains how to setup this project for developing
5 participants