Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added itemsListHeaderDuration to large-land player #6480

Merged
merged 1 commit into from
Jun 12, 2021

Conversation

litetex
Copy link
Member

@litetex litetex commented Jun 11, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • The ItemsListHeaderDuration element was missing in the large-land player which caused crashes on larger devices like TVs or tablets to crash

Problem was caused by #6441 / d921e2e

Fixes the following issue(s)

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

@TobiGr TobiGr added the bug Issue is related to a bug label Jun 12, 2021
Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TobiGr TobiGr merged commit 547a1a9 into TeamNewPipe:dev Jun 12, 2021
@opusforlife2 opusforlife2 changed the title Added itemsListHeaderDuration to large-hand player Added itemsListHeaderDuration to large-land player Jun 12, 2021
@litetex litetex deleted the fixMissingitemsListHeaderDuration branch June 12, 2021 15:25
This was referenced Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on newpipe when pressing on chapter
2 participants