Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Tabs style checks #6346

Merged
merged 10 commits into from
Jun 8, 2021
Merged

Resolve Tabs style checks #6346

merged 10 commits into from
Jun 8, 2021

Conversation

imericxu
Copy link
Contributor

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Clean up equals methods
  • Add hashCode methods matching respective equals to resolve style check warnings

APK testing

On the website, the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

@imericxu imericxu force-pushed the tabs-style-check branch 3 times, most recently from 06d540c to 936270d Compare May 22, 2021 04:58
@imericxu
Copy link
Contributor Author

I see that my pull request has a lot more commits than other people’s; should I squash them?

@AudricV AudricV added the codequality Improvements to the codebase to improve the code quality label May 22, 2021
@imericxu imericxu force-pushed the tabs-style-check branch 2 times, most recently from d6ef7f1 to 99b83cc Compare May 24, 2021 16:19
@imericxu imericxu force-pushed the tabs-style-check branch from 99b83cc to 448989f Compare May 26, 2021 16:01
@Stypox
Copy link
Member

Stypox commented Jun 6, 2021

@imericxu no, that's ok

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, thank you!

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are now only three checkstyle warnings. Great :-)

@Stypox Stypox merged commit a2eead5 into TeamNewPipe:dev Jun 8, 2021
@Stypox Stypox mentioned this pull request Jun 9, 2021
1 task
This was referenced Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants