Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Crashes when no videos in last played and user interacts with playlistController fix #5971

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

sauravrao637
Copy link
Contributor

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • assert statments were used in the code which lead to crash and thus replaced with if clause

Fixes the following issue(s)

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

@sauravrao637 sauravrao637 changed the title IssueFixed#5968 App Crashes when no videos in last played and user interacts with playlistController fix Mar 31, 2021
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Stypox Stypox merged commit 29b44a1 into TeamNewPipe:dev Mar 31, 2021
@AudricV AudricV mentioned this pull request Mar 31, 2021
4 tasks
@sauravrao637 sauravrao637 deleted the issueFix5968 branch March 31, 2021 17:09
This was referenced Apr 11, 2021
tossj pushed a commit to tossj/NewPipe-legacy that referenced this pull request Apr 23, 2021
…x5968

App Crashes when no videos in last played and user interacts with playlistController  fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App Crashes when no videos in last played and user interacts with playlistController
2 participants