Change Video not available PNG image to a vector drawable

[sherlockbeard]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Fixes #5609

Fixes the following issue(s)

removed png image and cropped and changed into vector drawable.

[Stypox]

Uh, interesting :-)
Remove the ic_ from the file name, ic_ stands for "icon" but this is not an icon ;-)

[Stypox]

I tried this, but the image seems to me a little bit uncentered. Could you improve the vector drawable by making sure the two points representing the nose lie at the center?

[sherlockbeard]

which one is better ?
1)

[Stypox]

I prefer the first, but maybe just put it a little bit to the right and add some padding (like before)

[sherlockbeard]

current

[Stypox]

@sherlockbeard that looks good, thank you for the changes :-D
I'm gonna keep this open for some days, and if nobody complains I'm gonna merge it @TobiGr @TiA4f8R @mhmdanas @opusforlife2

[AudricV]

Just a thing that I want to know is your advice about the background color of the monkey. Should this be black or grey like on the PNG image before?

[Stypox]

@TiA4f8R I think this is ok. One could argue that it should be inverted for white theme, though, what do you think?

[opusforlife2]

How about black (like in the preview images) for black theme, dark grey for dark theme, and light grey for light theme?

[AudricV]

Nice idea!

[Stypox]

@sherlockbeard please create three different drawables with the same shape but with different colors:

• white background & black foreground for white theme
• gray background & white foreground for dark theme
• black background & white foreground for black theme

And then select the correct drawable according to the current theme.

[triallax]

@sherlockbeard where did you get the vector drawable from? Did you make it yourself?

[sherlockbeard]

@mhmdanas Converted the image online. Then positioned it by changing the value's in Editor.

[alienthief]

@sherlockbeard thank you for this. Could you zoom out the sad face a bit and move the bellow text up in the video window? It would be more convenient as I mentioned in my issue (the one this PR fixes)

[Stypox]

@alienthief I don't think the image should be further zoomed out, and moving the error panel higher is not related to this PR

[Stypox]

Maybe in the XML you can set the background color of detailThumbnailImageView to the same color as important text (e.g. check the color of the video title and copy that)

[TobiGr]

Thank you. That's what I get on a TV / tablet

Screenshots

[TacoTheDank]

@mhmdanas Converted the image online. Then positioned it by changing the value's in Editor.

Did you use some sort of online SVG path editor, or is there an actual site that can convert images to vectors? I'm interested to know what site you used to do this 🤔

[sherlockbeard]

@TacoTheDank
https://shapeshifter.design/
https://vectr.com

[TobiGr]

@sherlockbeard CAn you please address #5925 (comment)

[Stypox]

@sherlockbeard ping

[sherlockbeard]

@TobiGr @Stypox . No i don't think i can mention the #5925 . i tried it only in mobile before the comment .After testing it on tablet i got the same result as in #5925 . I tried to search for a solution but i was not able to come up with a answer . Sorry i am noob developer .

[nadiration]

@sherlockbeard Did you abandon thid? This is kinda important. We've been waiting for this.

[sherlockbeard]

@nadiration . Sorry i have to abandon this pull request . i will be closing this pull request

[nadiration]

@nadiration . Sorry i have to abandon this pull request . i will be closing this pull request

@sherlockbeard May I ask why? Just curious it seemed to work fine

[sherlockbeard]

@nadiration actually it is not working for android tv or tablet . anything with large screen size
#5925 (comment)

[nadiration]

@sherlockbeard This may be fixed later on as phone users are the majority and it's working fine there?? This is really useful feature.

[triallax]

@nadiration just because phone users are the majority does not mean we ignore the rest (even temporarily).

[TobiGr]

there is an additional fragment_video_detail.xml in the land layout directory for tablets and TVs. You did not modify it.

[sherlockbeard]

i have decided to open a new pull request and fix the issue . Thanks @TobiGr for pointing me in the right direction