Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace FrameLayout with FragmentContainerView where applicable #5882

Merged
merged 1 commit into from
Mar 27, 2021
Merged

Replace FrameLayout with FragmentContainerView where applicable #5882

merged 1 commit into from
Mar 27, 2021

Conversation

TacoTheDank
Copy link
Member

@TacoTheDank TacoTheDank commented Mar 22, 2021 •
edited
Loading

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Fixes the following issue(s)

APK testing

https://github.com/TeamNewPipe/NewPipe/suites/2319358795/artifacts/48762467
I tested with my Android 10 phone and everything worked fine. However, I need people with tablets and tvs to test the video details page and make sure the related streams section works properly, please!

Due diligence

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@triallax triallax added codequality Improvements to the codebase to improve the code quality feature request Issue is related to a feature in the app labels Mar 23, 2021
Redirion
Redirion approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@Redirion Redirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Stypox
Stypox approved these changes Mar 27, 2021
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you :-)

@Stypox Stypox merged commit 08d8f25 into TeamNewPipe:dev Mar 27, 2021
@TacoTheDank TacoTheDank deleted the fragmentcontainerview branch March 28, 2021 22:26
@TacoTheDank TacoTheDank mentioned this pull request Mar 30, 2021
Merged
This was referenced Apr 11, 2021
Closed
Merged
tossj pushed a commit to tossj/NewPipe-legacy that referenced this pull request Apr 23, 2021
@Stypox @tossj
Merge pull request TeamNewPipe/NewPipe#5882 from TacoTheDank/fragment…
58b81e2 
…containerview

Replace FrameLayout with FragmentContainerView where applicable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stypox Stypox Stypox approved these changes

@Redirion Redirion Redirion approved these changes

Assignees
No one assigned
Labels
codequality Improvements to the codebase to improve the code quality feature request Issue is related to a feature in the app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TacoTheDank @Redirion @Stypox @triallax