Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

About package internal revamp #5881

Merged
merged 3 commits into from
Mar 31, 2021
Merged

About package internal revamp #5881

merged 3 commits into from
Mar 31, 2021

Conversation

TacoTheDank
Copy link
Member

@TacoTheDank TacoTheDank commented Mar 22, 2021 •
edited
Loading

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Rename SectionsPagerAdapter to AboutStateAdapter
  • Rename related XML ids to make more sense
  • Remove unused related ids
  • Convert About package to Kotlin
  • Make the viewpager2-related stuff throw an IllegalStateException if the position is somehow neither POS_ABOUT nor POS_LICENSE (for debugging purposes, obviously)

APK testing

https://github.com/TeamNewPipe/NewPipe/suites/2317657319/artifacts/48708456

Due diligence

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
9.0% 9.0% Duplication

@TacoTheDank
Copy link
Member Author

Those are not duplicated lines, sonar
image

@triallax triallax added codequality Improvements to the codebase to improve the code quality feature request Issue is related to a feature in the app labels Mar 23, 2021
Stypox
Stypox requested changes Mar 28, 2021
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, thank you :-)

app/src/main/java/org/schabi/newpipe/about/StandardLicenses.kt Show resolved Hide resolved
app/src/main/res/layout/fragment_about.xml Outdated Show resolved Hide resolved
@TacoTheDank TacoTheDank requested a review from Stypox March 29, 2021 23:08
@Stypox Stypox merged commit 84e3f6c into TeamNewPipe:dev Mar 31, 2021
@Stypox
Copy link
Member

Stypox commented Mar 31, 2021

Thank you! :-)

@TacoTheDank TacoTheDank deleted the about_revamp branch March 31, 2021 15:38
This was referenced Apr 11, 2021
Closed
Merged
tossj pushed a commit to tossj/NewPipe-legacy that referenced this pull request Apr 23, 2021
@Stypox @tossj
Merge pull request TeamNewPipe/NewPipe#5881 from TacoTheDank/about_re…
f7b57a5 
…vamp

About package internal revamp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stypox Stypox Stypox approved these changes

Assignees
No one assigned
Labels
codequality Improvements to the codebase to improve the code quality feature request Issue is related to a feature in the app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TacoTheDank @Stypox @triallax