Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up unnecessary onCreate in settings fragments #5879

Merged
merged 1 commit into from
Mar 28, 2021
Merged

Clean up unnecessary onCreate in settings fragments #5879

merged 1 commit into from
Mar 28, 2021

Conversation

TacoTheDank
Copy link
Member

@TacoTheDank TacoTheDank commented Mar 22, 2021 •
edited
Loading

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • As far as I'm aware, we don't need onCreate in the settings fragments when using PreferenceFragmentCompat, as it calls its own base method (which subsequently calls onCreatePreferences at its end). Please correct me if I have forgotten something.

APK testing

https://github.com/TeamNewPipe/NewPipe/suites/2318767009/artifacts/48743154

Due diligence

@triallax triallax added the codequality Improvements to the codebase to improve the code quality label Mar 22, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@triallax triallax added the feature request Issue is related to a feature in the app label Mar 23, 2021
Stypox
Stypox approved these changes Mar 28, 2021
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I tested on API 19 and API 30 and everything looks fine.

@Stypox Stypox merged commit daa5b78 into TeamNewPipe:dev Mar 28, 2021
@TacoTheDank TacoTheDank deleted the clean-oncreatepreferences branch March 28, 2021 22:25
This was referenced Apr 11, 2021
Closed
Merged
tossj pushed a commit to tossj/NewPipe-legacy that referenced this pull request Apr 23, 2021
@Stypox @tossj
Merge pull request TeamNewPipe/NewPipe#5879 from TacoTheDank/clean-on…
244793f 
…createpreferences

Clean up unnecessary onCreate in settings fragments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stypox Stypox Stypox approved these changes

Assignees
No one assigned
Labels
codequality Improvements to the codebase to improve the code quality feature request Issue is related to a feature in the app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TacoTheDank @Stypox @triallax