-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to ExoPlayer 2.13.2 #5856
Conversation
I have tested on my Pixel 4a (Android 11): basic video playback, play, pause and subtitles tested. Works so far, so any more feedback is appreciated. |
app/src/main/java/org/schabi/newpipe/player/resolver/PlaybackResolver.java
Outdated
Show resolved
Hide resolved
Overall very nice at a quick glance. Also, thanks for this; I was having trouble figuring out how to update ExoPlayer to 2.13 in another repository, so this will help a ton! (You can ignore this little nitpick of mine, since it's not important at all, but I feel that the changes concerning the ExoPlayer 2.13.x upgrade should be a separate commit from the changes that concern previous ExoPlayer updates (the MediaItem builders, setPlayWhenReady, setMediaSource, etc.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good at a firsf glance, thank you!
I tested a little bit: functionality-wise everything works fine, but the play-pause buttons always show the "Pause" icon even when the video is paused @Redirion |
I have restored the "onPlayerStateChanged" listener. The splitting up into "onPlaybackStateChanged" and "onPlayWhenReadyChanged" was causing the issues. This further simplifies this PR and makes it easy to merge in my opinion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested, everything works fine. Thanks :-)
Update to ExoPlayer 2.13.2
What is it?
Description of the changes in your PR
Updates ExoPlayer and fixes related deprecations where applicable.
@TacoTheDank I have also changed the setPlayWhenReady calls to play() and pause() where appropriate
APK testing
the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
Due diligence