Add Japanese translation of README #5468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiangRongLin
added
the
localisation / translation
XiangRongLin
requested changes
Jan 21, 2021
|
Yes. The country code for Japan is jp, but the language code is ja. |
|
@Ryota-Hasegawa could you also please add a link to |
|
@mhmdanas Done. |
|
@XiangRongLin can you figure out how to remove your requested changes and approve the PR instead? I can't merge the PR unless you do so. |
XiangRongLin
approved these changes
Jan 23, 2021
|
@mhmdanas done |
|
Thank you for merging :) |
ghost
mentioned this pull request
tossj
pushed a commit
to tossj/NewPipe-legacy
that referenced
this pull request
Apr 21, 2021
Add Japanese translation of README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Translate README into Japanese
Fixes the following issue(s)
Relies on the following changes
Due diligence