-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add APK testing section to PR template #5465
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because normal users don't know that the CI process produces an APK and where it is.
@XiangRongLin @mhmdanas Yes I understand. |
Exception
Crash log
|
This report by different device:- Exception
Crash log
|
@XiangRongLin yes, I agree that it was too early for my PR to be merged. |
@brnwlshubh thanks for the feedback. This thread is about adding how to get the APK from a pull request. |
@XiangRongLin Sure sir |
triallax
approved these changes
Jan 27, 2021
ghost
mentioned this pull request
Apr 11, 2021
tossj
pushed a commit
to tossj/NewPipe-legacy
that referenced
this pull request
Apr 21, 2021
Because normal users don't know that the CI process produces an APK and where it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Fixes the following issue(s)
APK testing
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
Due diligence
fyi @mhmdanas
@brnwlshubh Would you find the description under the APK testing section sufficient for someone who hasn't used github beforehand?