Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add APK testing section to PR template #5465

Merged
merged 1 commit into from
Jan 30, 2021

Conversation

XiangRongLin
Copy link
Collaborator

What is it?

  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Fixes the following issue(s)

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

fyi @mhmdanas

@brnwlshubh Would you find the description under the APK testing section sufficient for someone who hasn't used github beforehand?

Because normal users don't know that the CI process produces an APK and where it is.
@brnwlshubh
Copy link

@XiangRongLin @mhmdanas Yes I understand.

@brnwlshubh
Copy link

Exception

  • User Action: ui error
  • Request: App crash, UI failure
  • Content Country: IN
  • Content Language: en-GB
  • App Language: en_GB
  • Service: none
  • Version: 0.20.8
  • OS: Linux samsung/on7xeltedd/on7xelte:8.1.0/M1AJQ/G610FDDU1CSK2:user/release-keys 8.1.0 - 27
Crash log

java.lang.NullPointerException: Attempt to invoke virtual method 'android.widget.RelativeLayout org.schabi.newpipe.databinding.ChannelHeaderBinding.getRoot()' on a null object reference
	at org.schabi.newpipe.fragments.list.channel.ChannelFragment.handleResult(ChannelFragment.java:443)
	at org.schabi.newpipe.fragments.list.channel.ChannelFragment.handleResult(ChannelFragment.java:69)
	at org.schabi.newpipe.fragments.list.BaseListInfoFragment.lambda$startLoading$0$BaseListInfoFragment(BaseListInfoFragment.java:135)
	at org.schabi.newpipe.fragments.list.-$$Lambda$BaseListInfoFragment$Gn1fP3-8OJnktT5gkmUmbW-egTg.accept(Unknown Source:4)
	at io.reactivex.rxjava3.internal.observers.ConsumerSingleObserver.onSuccess(ConsumerSingleObserver.java:62)
	at io.reactivex.rxjava3.internal.operators.single.SingleObserveOn$ObserveOnSingleObserver.run(SingleObserveOn.java:81)
	at io.reactivex.rxjava3.android.schedulers.HandlerScheduler$ScheduledRunnable.run(HandlerScheduler.java:123)
	at android.os.Handler.handleCallback(Handler.java:790)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:164)
	at android.app.ActivityThread.main(ActivityThread.java:7000)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:441)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1408)


@brnwlshubh
Copy link

This report by different device:-

Exception

  • User Action: ui error
  • Request: App crash, UI failure
  • Content Country: IN
  • Content Language: en-IN
  • App Language: en_IN
  • Service: none
  • Version: 0.20.8
  • OS: Linux Android 10 - 29
Crash log

java.lang.NullPointerException: Attempt to read from field 'androidx.appcompat.widget.AppCompatButton org.schabi.newpipe.databinding.ChannelHeaderBinding.channelSubscribeButton' on a null object reference
	at org.schabi.newpipe.fragments.list.channel.ChannelFragment.updateSubscribeButton(ChannelFragment.java:353)
	at org.schabi.newpipe.fragments.list.channel.ChannelFragment.lambda$monitorSubscription$1$ChannelFragment(ChannelFragment.java:247)
	at org.schabi.newpipe.fragments.list.channel.-$$Lambda$ChannelFragment$00sQ8kobTMBsYnX1bMmu1QeN9lg.accept(Unknown Source:4)
	at io.reactivex.rxjava3.internal.observers.LambdaObserver.onNext(LambdaObserver.java:63)
	at io.reactivex.rxjava3.internal.operators.observable.ObservableObserveOn$ObserveOnObserver.drainNormal(ObservableObserveOn.java:201)
	at io.reactivex.rxjava3.internal.operators.observable.ObservableObserveOn$ObserveOnObserver.run(ObservableObserveOn.java:255)
	at io.reactivex.rxjava3.android.schedulers.HandlerScheduler$ScheduledRunnable.run(HandlerScheduler.java:123)
	at android.os.Handler.handleCallback(Handler.java:883)
	at android.os.Handler.dispatchMessage(Handler.java:100)
	at android.os.Looper.loop(Looper.java:214)
	at android.app.ActivityThread.main(ActivityThread.java:7405)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:502)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:980)


@triallax
Copy link
Contributor

@XiangRongLin yes, I agree that it was too early for my PR to be merged.

@XiangRongLin
Copy link
Collaborator Author

@brnwlshubh thanks for the feedback.

This thread is about adding how to get the APK from a pull request.
So if you have more information, add that to the other thread #5464 and not here

@brnwlshubh
Copy link

@XiangRongLin Sure sir

@XiangRongLin XiangRongLin added the meta Related to the project but not strictly to code label Jan 20, 2021
@triallax triallax merged commit 522d6d8 into TeamNewPipe:dev Jan 30, 2021
This was referenced Jan 30, 2021
@XiangRongLin XiangRongLin deleted the pr_template_apk branch January 30, 2021 13:14
tossj pushed a commit to tossj/NewPipe-legacy that referenced this pull request Apr 21, 2021
Because normal users don't know that the CI process produces an APK and where it is.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to the project but not strictly to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants