disable restoring brightness if brightness gesture is disabled #5283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redirion
reviewed
Dec 28, 2020
| @@ -2048,6 +2048,10 @@ private void setupBrightness() { | |||
| // Apply system brightness when the player is not in fullscreen | |||
| restoreDefaultBrightness(); | |||
| } else { | |||
| // Do not restore if user has disabled brightness gesture | |||
| if (!PlayerHelper.isBrightnessGestureEnabled(getContext())) { | |||
There was a problem hiding this comment.
you can replace getContext() with activity here
Redirion
approved these changes
Dec 29, 2020
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Fixes the following issue(s)
APK testing
debug.zip
Due diligence