-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract settings import #5225
Extract settings import #5225
Conversation
It handles locating specific NewPipe files based on the home directory of the app.
ExportTest provides no value. ImportTest creates temporary files even if not needed.
c675ee6
to
716d795
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you!
@XiangRongLin I am unable to run
If I make |
@Stypox Did you sync the Gradle files? Because the mockito-inline dependency should fix the problem with mocking final classes/methods |
@Stypox the |
…_settings_import Extract settings import
What is it?
Description of the changes in your PR
ContentSettingsFragment
intoContentSettingsManager
andZipHelper
ContentSettingsManager
NewPipeFileLocator
which resolves the db and settings files. Inject it intoContentSettingsManager
ExportTest
. No benefit with only one testAPK testing
app-debug.ziphttps://github.com/TeamNewPipe/NewPipe/actions/runs/459642451
Due diligence
Notes