Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a notification instead of a ProgressDialog in MissionAdapter. #5142

Conversation

Isira-Seneviratne
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Display the progress of the hash calculation in MissionAdapter using a notification instead of a ProgressDialog, as the latter has been deprecated in favor of either a ProgressBar or a progress notification.

Screenshot_20201211-074647748

APK testing

app-debug.zip

Due diligence

@Isira-Seneviratne Isira-Seneviratne force-pushed the Use_notification_instead_of_ProgressDialog branch from 942719c to 917f459 Compare December 12, 2020 23:51
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on API 19, 24 (real device), 29 (tv) and 30, everything worked. Thank you!

(unrelated to this PR: why is the checksum of a download not always the same on API 19, while it is on other APIs?)

@Stypox Stypox merged commit 40fcd93 into TeamNewPipe:dev Dec 15, 2020
@triallax
Copy link
Contributor

Who doesn't love them some non-deterministic checksums?

@Isira-Seneviratne Isira-Seneviratne deleted the Use_notification_instead_of_ProgressDialog branch December 15, 2020 08:50
This was referenced Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants