Extract export database logic into own class #5059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Separate it from the UI. - Add happy path unit test.
XiangRongLin
force-pushed
the
content_settings_manager
branch
from
f5c65c3
to
f7f0029
Compare
|
I added the setting |
Stypox
approved these changes
Dec 15, 2020
XiangRongLin
commented
Dec 15, 2020
| private lateinit var newpipeDb: File | ||
| private lateinit var newpipeSettings: File | ||
|
|
||
| @Before |
There was a problem hiding this comment.
Well from refactoring too much stuff around, i apparently created a beforeClass method annotated @Before. I'll fix this later on in my next PR.
There was a problem hiding this comment.
Please create a separate PR for this
TobiGr
reviewed
Dec 15, 2020
| @@ -131,6 +129,8 @@ public void onCreatePreferences(final Bundle savedInstanceState, final String ro | |||
| newpipeSettings = new File(homeDir + "/databases/newpipe.settings"); | |||
| newpipeSettings.delete(); | |||
|
|
|||
| manager = new ContentSettingsManager(homeDir); | |||
There was a problem hiding this comment.
That causes the build to fail. Can you fix that, please?
There was a problem hiding this comment.
Oh, how is this possible? I ran the tests successfully on my machine...
There was a problem hiding this comment.
WOW, i see where this is coming from. PR coming
XiangRongLin
added a commit
to XiangRongLin/NewPipe
that referenced
this pull request
Dec 15, 2020
TeamNewPipe#5176 changed `homeDir` from type `String` to `File`. TeamNewPipe#5059 was based on `homeDir` being a `String`. It was incorrectly auto-resolved by git.
4 tasks
XiangRongLin
added a commit
to XiangRongLin/NewPipe
that referenced
this pull request
Dec 15, 2020
TeamNewPipe#5176 changed `homeDir` from type `String` to `File`. TeamNewPipe#5059 was based on `homeDir` being a `String`. It was incorrectly auto-resolved by git.
5 tasks
2 tasks
spvkgn
pushed a commit
to spvkgn/NewPipe
that referenced
this pull request
Aug 4, 2021
TeamNewPipe#5176 changed `homeDir` from type `String` to `File`. TeamNewPipe#5059 was based on `homeDir` being a `String`. It was incorrectly auto-resolved by git.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
With this seperation, unit tests can be introduced. I just added one as proof of concept for now.
If this style is ok i would work on extracting more stuff out.
This also allows cheap unit tests instead of comparatively expensive androidTests.
APK testing
app-debug.zip
Due diligence