Make ErrorInfo contructor public #4995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To me it still goes into loop of restart when I report. |
|
@okan35 What device/software version are you using. I retried it with the zip from here on my phone and on an Android 4.4 emulator and it shows me the error screen there. |
|
I use Sony xperia xz premium, android version is android 9. I just went to a video from trending and saw error report and just clicked report. |
|
@okan35 I retried it with an android 9 emulator and can't reproduce it. Must be something specific to your device maybe |
Allows the library behind Parceable to crete an object of the class.
|
Can confirm the issue has been fixed, LGTM |
|
@TiA4f8R that seems to be a totally different error, this one would take you into a loop of the app opening and closing on it's own. |
|
Works fine, app doesn't crash. |
5 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Fixes the following issue(s)
APK testing
app-debug.zip
Note that loading comments always throws an error in this apk, since i changed the extractor for easier manual testing
Due diligence
@TobiGr @Stypox