-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable lint #4588
Enable lint #4588
Conversation
I'm not sure if merging is a good idea. You're adding a file with 27k lines of XML. It's pretty much impossible to review this. You don't explain how you added created this file (I'm pretty sure you didn't hand craft it), so it remains unclear how this linting system would have to be maintained in the future by the team. Please elaborate. Also, it would be better to open an issue first which you can then reference here. Please create one. Quoting the contribution guidelines:
|
We can take a snapshot of the project's current set of warnings & errors specified by lint, and then use the snapshot as a baseline for future inspection runs so that only new issues are reported. The baseline snapshot will let us start using lint to fail the build without having to go back and address all existing issues first. All the subsequent checks are will have to go through lint now. |
Please fix the errors and warnings instead of adding them to the blacklist: that's what pther PRs adding lint did. |
679bc75
to
2aeccc0
Compare
Closing this for now:
Feel free to reopen it when there is progress again. |
What is it?
Description of the changes in your PR
Current project has lint disabled. As a result of which, any new commit which is scheduled to go live may not pass the list of checks provided by android lint. To learn the list of checks that are done by lint, navigate here.
This PR enables lint workflow integration by creating a baseline file which includes all errors (1) & warnings (89) in the current project & treat them as a baseline. Any new commit will now throw an error if they do not follow the lint standard guideline.
Implementation