Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore license pop-up when orientation changes #4127

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Restore license pop-up when orientation changes #4127

merged 1 commit into from
Sep 2, 2020

Conversation

nmurali94
Copy link

@nmurali94 nmurali94 commented Aug 15, 2020 •
edited
Loading

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Keep license pop-up when screen is rotated

Fixes the following issue(s)

Agreement

Stypox
Stypox requested changes Aug 15, 2020
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good to me. Thank you!

app/src/main/java/org/schabi/newpipe/about/LicenseFragment.java Outdated Show resolved Hide resolved
@TobiGr TobiGr added bug Issue is related to a bug GUI Issue is related to the graphical user interface labels Aug 15, 2020
TobiGr
TobiGr approved these changes Aug 16, 2020
View reviewed changes
Copy link
Contributor

@TobiGr TobiGr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you messed up your history. I fixed that for you.
@Stypox Feel free to merge once you think it is good to go.

@Stypox Stypox self-requested a review September 2, 2020 14:23
Stypox
Stypox approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

@Stypox Stypox merged commit a84b54f into TeamNewPipe:dev Sep 2, 2020
This was referenced Sep 27, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wb9688 wb9688 wb9688 left review comments

@Stypox Stypox Stypox approved these changes

@TobiGr TobiGr TobiGr approved these changes

Assignees
No one assigned
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

License dialog disappear after device rotation
4 participants
@nmurali94 @TobiGr @Stypox @wb9688