-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EditorConfig #3394
Add EditorConfig #3394
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like those rules. I'm a little bit worried if changing all of the strings.xml files could cause problems with weblate. Also, is it ok to edit changelogs of older versions (I assume it is, I'm pointing out this just to make sure)? Other than that I think this can be merged.
Maybe, cc @B0pol and @TobiGr. There are some issues that could actually be fixed through Weblate, however some others have to be fixed this way. I also noticed that some translations don't have
Yes, F-Droid only looks at the changelog in the commit that was tagged for that release. |
I didn't look at whether files are actually indented by 4 spaces though.
Co-Authored-By: Tobias Groza <[email protected]>
I've a question: does this automatically set the rule for imports? Because often you remove the wildcard imports .*. But as it's automatically done by intellij, people revert that. |
@B0pol: No, that's not possible in EditorConfig, as that's some IntelliJ-specific setting, however we could add |
What is it?
Description of the changes in your PR
This PR adds an EditorConfig. EditorConfig is some standard to set certain code style related settings in different editors and IDEs. I've also changed all files (except
gradlew.bat
) to use LF line ending, replaced all tabs with 4 spaces, have a newline at the end, and to not have trailing whitespace. I didn't look at whether files that were formatted with spaces are actually formatted with 4 spaces, or whether the indentation is correct.Agreement