Notification Improvements

[cool-student]

• add MediaStyle notifications for Background and Popup playback
• reduce excessive notification updating ( / recreating of Notification.Builder object) when playing background / popup media
• add new buffering state indicator (can be disabled)
• upscale close icon / downscale replay icon
• add notification slot settings
• move notification settings to appearance
• fix Metadata (song title, artist and album art) sometimes not being set correctly
• other misc notification fixes

---

debug apk (@Stypox 22/09/2020 b4e073c): app-debug.zip

closes #690 closes #1660 closes #2845 closes #1104 closes #1207 closes #3149 closes #3170
closes #1527 closes #1242 closes #1568 closes #1574 closes #1596 closes #2007
closes #3436 closes #3071 closes #4031 closes #4033 closes #2976 closes #2397 closes #228
closes #4286

• I carefully read the contribution guidelines and agree to them.

[opusforlife2]

Uploads to Github are convenient to share the link with a download manager, if one doesn't want to rely on the browser. Firefox Send is like Mega in this respect. It forces the use of the browser for the download.

[wb9688]

Nice work! I'll take a look at it later (but I'm not going to do an extensive code review).

@opusforlife2: Firefox Send does that as that's the only way to have end-to-end encryption. However that's kinda off-topic here.

[opusforlife2]

Ah. Good to know.

[opusforlife2]

The compact view item selector should be a list of checkboxes, with a toast or an alert showing up if the user tries to select more than 3.

Edit: No deleteIntent yet? If you do implement it, make sure that it is disabled if one of the buttons is Close.

Is there no buffering animated icon for the play button position?

[Stypox]

Would this also solve #1574 and all of its duplicates? By the way, I improved the markdown in the pr description and added a "Closes" string before every issue so that github knows it should close each of these issues. Also, there is no need to upload apk files to an external service like Firefox Send, you can instead zip them and upload them directly here on github. @cool-student thank you :-D

[njmdietrich]

I have been using the debug apk for a few days and I can report that this PR fixes issue #3071 - although the "Unknown" notification will still come up when you press play on connected headphones, but it can be closed properly now. #2976 is probably a duplicate of the other issue so would be fixed too.
The only (minor) issue I've found with the PR is playing live streams on YouTube - the notification updates every few seconds like before, but every time it happens the play indicator jumps to the beginning for a second or so.

[vkhomenk]

Link has expired

[Stypox]

@cool-student you can upload the apk directly on GitHub by zipping it ;-)

[opusforlife2]

Bug: #3201 (comment)

[wb9688]

Could you use XML drawables instead of PNG drawables?

[Rorschach1010]

Download link expired, can someone please share it or even better, upload it to git itself?

[opusforlife2]

@Rorschach1010 app-debug-notifications-v8-8.zip

[Rorschach1010]

thanks a bunch, will test it tomorrow.

[Rorschach1010]

@Rorschach1010 app-debug-notifications-v8-8.zip

I was able to test this 2 days now and tbh it didn't solve the issue. Not sure if this is an important detail but instead of the normal newpipe notification icon, in this version it was replaced with the android standard download icon (arrow pointing down with a line at the bottom) in the notification bar.
Other then that, nothing changed and newpipe still started when I start my car.

[opusforlife2]

@Rorschach1010 Are you talking about this issue? #3071 (comment)

[Rorschach1010]

@Rorschach1010 Are you talking about this issue? #3071 (comment)

I was lead here from #1596 but it sounds like its the same issue. I didn't see your mentioned issue but now that I read it, what you posted there pretty much sums it up

If Newpipe was your last played audio app, then events such as connecting a headphone can automatically try to start such apps. If you have the ability to change tracks using the volume button, that can have this effect as well.

[wb9688]

I rebased this PR and fixed the Checkstyle errors. Here is the new APK:
app-debug.apk.zip.

Edit: I also replaced the new drawables with vector drawables, but I didn't test it yet on Android 4.4 and that's not in the above APK.

I'll test and take a look at the code soon, and maybe fix it.

^{PS: pre-rebase branch could be found at https://github.com/wb9688/NewPipe/tree/old-notification-improvements.}

[MD77MD]

oh boy... no i cant access the play queue using apk from #3178 (comment) ... although i did everything you asked

however and just to clarify, i uninstalled it and reinstalled the apk from #3178 (comment) ....the notification on Lock screen shows fine but once i pause it, it disappears and cant resume playback unless i unlock the device and go back to newPipe like what i said in #3178 (comment)

[Stypox]

@MD77MD do other buttons work fine? And does the notification disappear completely when you tap pause, or does it only disappear from the lock screen while still being accessible from the drag-down menu in the unlocked phone?

[Stypox]

@TheGinGear that's a known issue, but won't be fixed here

[MD77MD]

@MD77MD do other buttons work fine? And does the notification disappear completely when you tap pause, or does it only disappear from the lock screen while still being accessible from the drag-down menu in the unlocked phone?

@avently all buttons work fine... the notification only disappears from lock screen but still available at the notification center (if that what you mean by the drag-down menu)

p.s: just to clarify because i can attach screen shot... what i mean by notification background is the background on the lock screen with the opend video's thumbnail and laid on top of it the 3 player buttons.

edit: sorry... I was supposed to tag @Stypox not avently

[TobiGr]

@MD77MD We have a problem. @Stypox and I cannot reproduce your bug, because KitKat emulators suck. We agreed on merging this PR, because there are no problems with it except for KitKat users.
@Stypox might get a hand on a KitKat device and fix your problems. If he does not, we try to reach out to other devs with KitKat devices to help us.
edit: @mqus Can you help us here?

[TobiGr]

thanks to everyone involved!

[opusforlife2]

HALLELUJAH!

[B0pol]

21 issues fixed! congrats

[MD77MD]

@MD77MD We have a problem. @Stypox and I cannot reproduce your bug, because KitKat emulators suck. We agreed on merging this PR, because there are no problems with it except for KitKat users.
@Stypox might get a hand on a KitKat device and fix your problems. If he does not, we try to reach out to other devs with KitKat devices to help us.
edit: @mqus Can you help us here?

its ok..i don't think it's worth blocking the merger. we can always open a new issue if any of the users complain about it.

[opusforlife2]

Since the RC is now available, locking this thread because too many people get spammed with notifications.

[TobiGr]

@MD77MD Can you open a new issue with all the details about the problem and ping mqus?