Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReCaptchaActivity #2527

Merged
merged 3 commits into from
Aug 17, 2019
Merged

Fix ReCaptchaActivity #2527

merged 3 commits into from
Aug 17, 2019

Conversation

Stypox
Copy link
Member

@Stypox Stypox commented Aug 17, 2019

This pr fixes two problems with the ReCaptchaActivity:

  • it crashes on activity startup due to a hidden EditText, see ui crashes when google serves a captcha page #2484
  • it always shows youtube's main page ("https://www.youtube.com"), even though the ReCaptchaException was thrown while loading a different page. The main page sometimes contains the ReCaptcha (so there is no problem), but other times it does not since YouTube only blocks a specific page. The specific page that requested a ReCaptcha challenge is now loaded instead, so that the ReCaptcha is always shown.

Fixes #2484
Corresponding extractor pr: TeamNewPipe/NewPipeExtractor#186
Testing apk: app-debug_2.zip

Stypox added 3 commits August 17, 2019 09:25
Sometimes YouTube introduces recaptchas only on some pages. By loading the url inside the ReCaptchaException into ReCaptchaActivity's webview, the page that originally caused the problem is shown. The user can then solve the page-specific recaptcha.
@Stypox Stypox added bug Issue is related to a bug GUI Issue is related to the graphical user interface labels Aug 17, 2019
@theScrabi theScrabi merged commit c89f0e5 into TeamNewPipe:dev Aug 17, 2019
This was referenced Aug 17, 2019
@blacklight447
Copy link

I'm still having crashes when recaptcha appears ;-;

@Stypox
Copy link
Member Author

Stypox commented Aug 31, 2019

Are you able to get a crash report?

@blacklight447
Copy link

I will the next time it crashes (I only get captcha's on occasion)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui crashes when google serves a captcha page
3 participants