Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed playlist order #11566

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

nicholasala
Copy link

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

When user has not yet adjusted manually the playlists order the lists in "Bookmarked Playlists" and "add to playlist" dialog don't have the same order. Now in this phase both lists are sorted using case insensitive order. While after manual sorting from user both list keep the same order.

Before/After Screenshots/Screen Record

  • Before:

Screenshot from 2024-09-26 14-02-30

Screenshot from 2024-09-26 14-02-39

  • After:

Screenshot from 2024-09-26 14-16-34

Screenshot from 2024-09-26 14-16-41

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

…playlist" dialog list. Now both lists are sorted using case insensitive order if the user has not yet adjusted manually the order.
@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Sep 26, 2024
Copy link

sonarcloud bot commented Sep 26, 2024

@AudricV AudricV added bug Issue is related to a bug GUI Issue is related to the graphical user interface database Issue is related to database operations playlist Anything to do with playlists in the app labels Sep 27, 2024
@TobiGr TobiGr requested a review from Stypox October 5, 2024 18:34
@ShareASmile ShareASmile added the waiting for peer review Most of the work is done, PR is now ready for a review label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug database Issue is related to database operations GUI Issue is related to the graphical user interface playlist Anything to do with playlists in the app size/small PRs with less than 50 changed lines waiting for peer review Most of the work is done, PR is now ready for a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange Playlist Order in the Add to Playlist preview
4 participants