Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced symlink (causing issues with windows) with the file the symlink was pointing to #11482

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Thompson3142
Copy link
Contributor

@Thompson3142 Thompson3142 commented Aug 28, 2024

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

When the git repo is cloned from a windows machine it does not (always) recognize symlinks. I simply copied the contents of the file the symlink was pointing to, into the file with the symlink.

Fixes the following issue(s)

#10963

Due diligence

@github-actions github-actions bot added the size/medium PRs with less than 250 changed lines label Aug 28, 2024
@Thompson3142
Copy link
Contributor Author

Thompson3142 commented Aug 28, 2024

If this change should be documented in some way to avoid errors when editing only one of the two existing files let me now. (Also my first pull request so be gentle :) )

@Thompson3142 Thompson3142 reopened this Aug 29, 2024
@Thompson3142
Copy link
Contributor Author

Thompson3142 commented Aug 29, 2024

Realized i copied a different file than the one which was actually referenced by the symlink, sorry for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/medium PRs with less than 250 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant