Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ask for consent before checking for updates #10790

Merged
merged 4 commits into from
Mar 29, 2024
Merged

Ask for consent before checking for updates #10790

merged 4 commits into from
Mar 29, 2024

Commits on Mar 28, 2024

  1. Move text from manual_update_title to check_for_updates

    @TobiGr
    TobiGr committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    1d3a69a View commit details
    Browse the repository at this point in the history

  2. Ask for consent before starting update checks 

    NewPipe is contacting its servers without asking for the users' consent. This is categorized as "tracking" by F-Droid (see #10785).

This commit disables checking for udpates by default and adds a dialog asking for the user's consent to automatically check for updates if the app version is eligible for them. After upgrading to a version containing this commit the user is asked directly on the first app start. On fresh installs however, showing it on the first app start contributes to a bad onboarding an welcoming experience. Therefore, the dialog is shown at the second app start.

Co-authored-by: Stypox <[email protected]>
    @TobiGr @Stypox
    TobiGr and Stypox committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    a3bbbf0 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. update_app_key default value should be false

    @Stypox
    Stypox committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    3703fed View commit details
    Browse the repository at this point in the history

  2. Improve new version checks before running

    @Stypox
    Stypox committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    9240268 View commit details
    Browse the repository at this point in the history