Fix notifying about old "new" streams #10494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for `FeedDAO.unlinkStreamsOlderThan(:offsetDateTime) ` Closes TeamNewPipe#10237
TobiGr
added
bug
TobiGr
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
6 tasks
Stypox
requested changes
Nov 16, 2023
app/src/main/java/org/schabi/newpipe/database/feed/dao/FeedDAO.kt
Outdated
Show resolved
Hide resolved
21 tasks
6 tasks
Co-authored-by: Stypox <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Stypox
approved these changes
Dec 7, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
After fetching new streams for the feed, "old" streams are removed from the database. However, if a channel contains only streams which are considered old, they are also removed. Thus they are shown as new when refreshing the feed the next time. For a more detailed explanation, read this comment in the original issue.
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence