Improve audio stream selection for video-only streams in the downloader #10446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… some typos in the class
Instead of searching for the first audio stream matching a compatible media format, this change makes SecondaryStreamHelper.getAudioStreamFor use methods isLimitingDataUsage, getAudioFormatComparator and getAudioIndexByHighestRank of ListHelper to get an audio stream which can be muxed into a video-only stream, if available. This allows users to download videos with the highest audio quality available if no resolution limit on mobile data usage has been set. The order of formats used to search a compatible audio stream has been kept.
AudricV
added
bug
|
Kudos, SonarCloud Quality Gate passed! |
3 tasks
|
Please add information about the strategy that is used to get the AudioStream to the method. That should help us to easily determine whether to use the method and/or how to modify it if the requirements change in the future. |
21 tasks
Stypox
requested changes
Dec 7, 2023
There was a problem hiding this comment.
Videos are usually downloaded to be kept for later, so most of the times the audio quality the user wants is unrelated to whether they are connected to mobile data or not. The optimal way would be to add a secondary menu in the download dialog for choosing the audio quality separately. But for now this is ok.
app/src/main/java/org/schabi/newpipe/util/SecondaryStreamHelper.java
Outdated
Show resolved
Hide resolved
Stypox
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Instead of searching for the first audio stream compatible with a media format, this change makes the method to get audio-only streams for video-only streams in the downloader (
SecondaryStreamHelper.getAudioStreamFor) use some methods used to get available audio streams for playback (isLimitingDataUsage,getAudioFormatComparatorandgetAudioIndexByHighestRankofListHelperclass).This means that the audio stream quality selection in the downloader will now follow the setting of a default video resolution on mobile data: if a resolution is set, the lowest audio stream should be selected, otherwise the highest audio stream should be selected. This behavior should be already applied for playback.
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence