Fix player audio focus not respecting mute #10275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiGr
added
bug
|
Last commit for including #10281 to fix snyk check, let me know if I need to undo it. |
|
We prefer |
J-Stutzmann
force-pushed
the
fix/audio-focus
branch
from
93b127d
to
282b0f8
Compare
J-Stutzmann
force-pushed
the
fix/audio-focus
branch
from
282b0f8
to
c06d61a
Compare
|
Kudos, SonarCloud Quality Gate passed! |
This was referenced Oct 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is right on the line between feature and bug, so I'm selfishly calling it a bug. Very straightforward fix, tested with no obvious problems.
What is it?
Description of the changes in your PR
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence