Refactor Player.useVideoSource logic and improve its comments #10195

AudricV · 2023-06-28T20:16:52Z

What is it?

Bugfix (user facing)

Description of the changes in your PR

This PR simplifies the logic of the useVideoSource method of the Player class and improves its comments. These changes should resolve the issues of video and text tracks renderers not enabling in some cases.

Detailed version of the changes:

don't check for isAudioOnly == !videoEnabled, as this prevents enabling again
video and text tracks renderers in some cases;
when reloading play queue manager if that's needed, disable or enable video
and text tracks renderers, as they may need to be enabled again in some cases
like starting a video in main player, opening play queue, switching to
background player on it and switching back to main player;
disable or enable video renderers also for streams with AUDIO_STREAM
StreamType, as doing so doesn't raise any issue and simplifies code;
reword and move some comments to make them easier to understand.

Fixes the following issue(s)

Fixes switching to background then main from playlist blanks out video #10147

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Please test intensively these changes, by switching between multiple player types and streams of different services and testing every combination possible, to ensure that I introduced no regression.

Due diligence

I read the contribution guidelines.

TobiGr

The code changes make sense to me, but I have limited knowledge of the player. Somebody else might want to review this PR, too.

app/src/main/java/org/schabi/newpipe/player/Player.java

- don't check for isAudioOnly == !videoEnabled, as this prevents enabling again video and text tracks renderers in some cases; - when reloading play queue manager if that's needed, disable or enable video and text tracks renderers, as they may need to be enabled again in some cases like starting a video in main player, opening play queue, switching to background player on it and switching back to main player; - disable or enable video renderers also for streams with AUDIO_STREAM StreamType, as doing so doesn't raise any issue and simplifies code; - reword and move some comments to make them easier to understand.