Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Enqueue menu item even when no current video playing #8151

Open
5 tasks done
emjas92 opened this issue Apr 5, 2022 · 9 comments
Open
5 tasks done

Show Enqueue menu item even when no current video playing #8151

emjas92 opened this issue Apr 5, 2022 · 9 comments
Assignees
Labels
feature request Issue is related to a feature in the app

Comments

@emjas92
Copy link

emjas92 commented Apr 5, 2022

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

Always show the "Enqueue" menu item even when there is no current video playing, like how YouTube allows you to hover a thumbnail and "add to queue" at any time.

Why do you want this feature?

I like to queue up a bunch of videos to watch all in a row.
But currently I have to start playing the first video and minimise it, and then I can enqueue other videos.

Additional information

This is just for convenience to save a few seconds.

@emjas92 emjas92 added the feature request Issue is related to a feature in the app label Apr 5, 2022
@opusforlife2
Copy link
Collaborator

Related: #2611

@dtcxzyw
Copy link
Contributor

dtcxzyw commented Apr 16, 2022

@opusforlife2 How is this issue going now? If you are not working on the issue, I want to give it a try.

@emjas92
Copy link
Author

emjas92 commented Apr 16, 2022

Feel free to do it. I have not had time myself.

I suspect there's logic in the menu code that says "if a video is playing then show Enqueue option." The if condition would need to be removed.

I think the first video enqueued should load "minimised" but not start playing, to allow you to continue select videos to enqueue.

@SameenAhnaf
Copy link
Collaborator

Which player should be selected for enqueueing videos? Are we willing to have something like multiple queues? Such functionality was possible in pre-unified versions.

@opusforlife2
Copy link
Collaborator

@dtcxzyw Go ahead. Also, please keep the issue I linked in mind.

@emjas92
Copy link
Author

emjas92 commented Apr 19, 2022

Which player should be selected for enqueueing videos? Are we willing to have something like multiple queues?

Good questions.
I think the first enqueued video should follow the "Preferred open action" and "Autoplay" settings.

For example, my settings are 'show info' and 'autoplay on WiFi' - so I'd like the first enqueued video to open in the normal Video player but minimised so that I can continue adding videos from the same list.

If there's already a different queue, e.g background player, then Enqueue should add to that queue as it currently does.
Actually I don't know why there would be different queues for each player - wouldn't they all use the same queue?

@SameenAhnaf
Copy link
Collaborator

@emjas92 @dtcxzyw Please let me know wdyt about #5940 (comment).

Actually I don't know why there would be different queues for each player - wouldn't they all use the same queue?

Before 0.20.0, there used to be a feature for keeping background and popup queues separately alongside main player. Supose, you want to listen to music, then change your mood to watch tech videos. But you don't want to lose existing queue. This feature comes in handy. For long answer: #5864 (comment)

@dtcxzyw
Copy link
Contributor

dtcxzyw commented Apr 20, 2022

@emjas92 @SameenAhnaf

I think the first video/audio enqueued should remain paused. Users can click "Start playing" if it needs to play immediately.

The current implementation enqueues the video/audio to the background queue by default. The main queue will inherit the background queue when users want to play these streams in the main player. It works fine on my device.

As for multi-queue, I don't want to address three issues in a single PR. But I am willing to try to give a solution after fixing these two issues.

@dtcxzyw dtcxzyw mentioned this issue Apr 20, 2022
5 tasks
@TBN-MapleWheels
Copy link

@emjas92 @dtcxzyw Please let me know wdyt about #5940 (comment).

Actually I don't know why there would be different queues for each player - wouldn't they all use the same queue?

Before 0.20.0, there used to be a feature for keeping background and popup queues separately alongside main player. Supose, you want to listen to music, then change your mood to watch tech videos. But you don't want to lose existing queue. This feature comes in handy. For long answer: #5864 (comment)

You have no idea how much I miss this feature. I can't click on YouTube links in places like Discord without it wanting to clear the Queue. It's browser tabs for mobile (equivalent of Open In New Tab).

Anyways, on topic. It would make using the app feel more seamless to have an "Enqueue" option always available. Think about this from the user's perspective, it's easier yo train a user to select "Enqueue" in any scenario where you're building a queue of videos. It's intuitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants