Clicking timestamp shows Toast "Playing in popup mode", even if the player is already in popup mode.

[skyGtm]

Checklist

• I am using the latest version - v0.21.6 (pre-release)
• I checked, but didn't find any duplicates (open OR closed) of this issue in the repo.
• I have read the contribution guidelines given at https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md.
• This issue contains only one bug. I will open one issue for every bug report I want to file.

Steps to reproduce the bug

Play any Youtube video that has timestamps in description
(I used this: https://www.youtube.com/watch?v=aleEl74qkXU)

1. Go to video description
2. Click on time-stamp.

Note: This issue was first mentioned in #5523 (comment)

Actual behavior

Here is a screen record.

abc.mp4

Expected behavior

It should show "Playing in popup mode" toast message only if video was not playing in Popup mode.

Screenshots/Screen recordings

Logs

Device info

• Android version/Custom ROM version:
• Device model:

[laksh-21]

Hi @TobiGr I looked through the code and:

1. To know what mode the player is in, PlayerType of the Player is queried using getPlayerType() here.
2. NavigationHelper.playOnPopupPlayer() is the source of the Toast message here
   So, this function needs access to PlayerType of the Player to decide to show the Toast message or not, so I was wondering if passing the PlayerType through the hierarchy in which this function is called would be the best option for solving this issue.

Thanks :)

[vhouriet]

Hey @laksh-21, you can get the PlayerHolder instance with its getInstance() method. You then have access to the Player methods.

If you're not working on this issue anymore, I'd like to give it a try.

[laksh-21]

@vhouriet I'm not working on it, I was just looking into the issue to see if I could solve it. You can work on it if you want but get it assigned to you first :)

[vhouriet]

@laksh-21 Ok thanks, how do I get it assigned to me ? Sorry, I'm pretty new to Github.

[laksh-21]

@vhouriet just leave a comment here that you want to work on this issue. Maybe mention the author.
Also read the contribution guidelines.

[vhouriet]

I'd like to work on this issue.