Return to portrait after video finish in fullscreen

[niktss]

Checklist

• I am using the latest version - 0.21.0
• I checked, but didn't find any duplicates (open OR closed) of this issue in the repo.
• I have read the contribution guidelines given at https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md.
• This issue contains only one bug. I will open one issue for every bug report I want to file.

Steps to reproduce the bug

1. Use NewPipe in portrait mode with locked screen rotate
2. Launch a video and press the fullscreen button. Let it finish.

Actual behaviour

The video exits from fullacreen and NewPipe is stuck in landscape. You have to enable autorotate to fix it.

Expected behavior

NewPipe returns to portrait, the mode I launched the video from.

Screenshots/Screen recordings

Logs

Device info

• Android version/Custom ROM version: Lineage 17
• Device model: Galaxy A3(2017)

[sauravrao637]

Hi!
Thanks for reporting the issue and keep doing such good things :)
but it's no bug
I checked this out , if you have auto rotate enabled then the screen will not get stuck but if it's disabled then it's not bug it is the expected behavior.
Please check again on your device and tell if it's not the case

[niktss]

I know about auto rotate working. I was just shocked this is "the expected behaviour". I start fullscreen from portrait, why would I want to go landscape when I exit fullscreen?

[sauravrao637]

If you click again on full screen button , it will exit the full screen . Also you can check its the same case with the official YouTube app.
Let's see what the team has to say :)

[niktss]

I'm not sure if I'm doing it right, but in official YT, when a video is over, it doesn't exit fullscreen, but pressing any button to exit it returns it to portrait. It doesn't force me to use landscape after a video is over though, which is what NewPipe does and to me seems illogical.

If orientation is manually locked by me, and it's in portrait, and I'm therefore using the app in portrait, why would it make sense for it to change to landscape when a video is over in fullscreen? If I browsed to the video in portrait I probably want to browse to the next one in portrait too.

[sauravrao637]

Nor does NewPipe forces you :), if you tap on "full screen icon" you will successfully return to portrait.
When the rotation in locked but you choose fullscreen that means you want to use it in landscape now (in my opinion).
Maybe the team should create a poll regarding the same as all users are different and we should know opinion of the majority and work accordingly :)

[lokesh-krishna]

Glad to see this has already been reported and I'm in agreement. This should definitely not be the expected behaviour. Orientation should go back to portrait upon exiting full screen. Not only that, the UI also seems to get wonky after exiting full screen. Attaching screenshots to explain.

This is what the screen looks like upon first tapping on full screen from portrait. Tapping again goes full screen but upon exiting, this is what I get.

[NanyangTaiji]

Agree with all of you, it is a good suggestion, a simple adustment can fix the issue.

[Dakkaron]

This seems to be only happening in tablet mode (smallest width>=480dp), from my testing.

[lokesh-krishna]

Is it intentional behaviour in tablet mode though? Still seems like a bug. If anything, the fact that this works as expected in phone mode proves the point that what is now happening is not expected behaviour.

You're right about my display density being high though and reducing it did fix the issue for me. Your PR looks like exactly what we need and I hope it is merged soon.

[Dakkaron]

I personally don't think that tablet mode offers much, but it breaks quite a few of my expectations, while phone mode does exactly what I want.

It doesn't seem to me as if it was expected behaviour, but devs say it is.

I find it especially weird that tapping the fullscreen button at first doesn't even open fullscreen, but just toggles the locked orientation. Only the second press opens fullscreen.

Until it is merged you can use the debug build generated from the PR: https://github.com/TeamNewPipe/NewPipe/suites/2474591406/artifacts/53233850

[Dakkaron]

It's actually not possible to go back into portrait mode at all once you triggered this, except by manually unlocking the device rotation or closing NewPipe.
The very strange thing about that is that after triggering this, only NewPipe is stuck in the locked landscape mode. If you tab out of NewPipe, the OS and the other apps are still in locked portrait mode.
It actually took me about two months to figure out how to get out of the locked landscape mode in NewPipe without closing the app.

[Pentaphon]

This seems to be only happening in tablet mode (smallest width>=480dp), from my testing.

It happens on a clean install with my phone for me.

[Dakkaron]

This seems to be only happening in tablet mode (smallest width>=480dp), from my testing.

It happens on a clean install with my phone for me.

What is your smallest width? For that go to Developer Options in your phone's settings and check for the value under smallest width.

You can also try to manually force phone mode, by disableing tablet mode under the appearance settings in the NewPipe settings.

[Pentaphon]

This seems to be only happening in tablet mode (smallest width>=480dp), from my testing.

It happens on a clean install with my phone for me.

What is your smallest width? For that go to Developer Options in your phone's settings and check for the value under smallest width.

You can also try to manually force phone mode, by disableing tablet mode under the appearance settings in the NewPipe settings.

Ah you're right. This phone's smallest width is 411. My Newpipe is set to "auto" for tablet mode which is default. I guess I will turn it off but I shouldn't have to do that for Newpipe to not get stuck.

[opusforlife2]

I have tablet mode off, yet I still face this bug.

I'll paste here the solution I suggested in the RC issue:

Automatic return to portrait after the video is finished. OR, just stay in landscape fullscreen and exit directly to portrait upon tapping Back (instead of automatically going into a weird non-fullscreen but landscape hybrid.)

[Dangelman]

I agree with having it fixed. People who have autorotate disabled have it for a reason: they prefer portrait over landscape while browsing.

Basically, Newpipe stays in Landscape after playing a fullscreen video if you close the video without disabling fullscreen first.
I want it to return to portrait instead if I have autorotate disabled. Maybe add an option if you want to keep it a feature?

[Dakkaron]

I have a workaround that works quite nicely. I installed Key Mapper (https://play.google.com/store/apps/details?id=io.github.sds100.keymapper) and added the following setup:

Long Press Volume Up Button

• No constraints
• Action "Volume Up" with "Show Volume Dialog" and "Repeat"

Double Press Volume Up Button

• Constrained to Portrait Mode
• Action "Enable Auto Rotate" with "Delay before next action: 150ms"
• Action "Landscape Mode"

Double Press Volume Up Button

• Constrained to Landscape Mode
• Action "Enable Auto Rotate" with "Delay before next action: 150ms"
• Action "Portrait Mode"

This allows me to change the screen orientation with a double press of the volume up button (don't do this with the volume down button, because that messes up the screenshot key combination).
With that, the weird behaviour of NewPipe doesn't bother me, since I can just double press the volume button to set the orientation as I like.

[Mjmarahman]

Can this issue be fixed soon because I have been using newpipe for years and after the April update it has been frustrating to watch videos because of this problem. It is very infuriating and it should do what it used to do before. I tried to follow whatever that guy said where if you click on the full screen thing again it would go to potrait mode again, but no it doesn't and it goes back to full screen mode. I prefer using my phone on potrait mode after I leave a video just like every other app such as Netflix, YouTube and many other video platforms.

[Dakkaron]

Have you tried my workaround with the key mapper? I upgraded to Android 11 and it is still working for me

[opusforlife2]

but no it doesn't and it goes back to full screen mode

@Mjmarahman Please explain this. That button literally cannot take you to full screen mode because that can only happen if a video is played. If the Replay button is visible to you, then you're on the video details page in either portrait or landscape orientation. If your player is going into full screen but without playing the video, then something else is wrong.

[Mjmarahman]

@opusforlife2 I meant it doesn't go back to portrait mode. We literally just want it to go back to portrait mode after exiting the full screen that was on horizontal mode.

Step 1. Click on a video on portrait mode. Step 2. Click on Fullscreen mode. Step 3. It will go horizontal mode. Step 4. Play the video. Step 5. Exit by clicking full screen mode again. Step 6. You're in a forced horizontal mode especially when you do not have the auto rotate one. Step 7. To rotate it again, you have to click on the auto rotate again and do it every time you click on a single video on full screen.

[Mjmarahman]

Have you tried my workaround with the key mapper? I upgraded to Android 11 and it is still working for me

I would love to, but at the moment it just bothers me that the app doesn't do it itself and I had planned to use your method once I have time.

[niktss]

This is inaccurate. What the issue we all have is:

Bro, I literally described what you had done just without mentioning the "wait till you finish the video" because I literally have this problem either if I do not finish the video or I do finish the video. In your own words within the Actual behavior

Sorry, didn't mean to sound snappy at you. I was just frustrated at other people still asking what the issue is 1 year on, when we've all explained what the issue is.

[Mjmarahman]

Perfectly fine man, I'd be in your shoes as well and it is frustrating because this problem hasn't been solved at all for a long while. On Mar 6, 2022, at 2:48 PM, Frivolous2 ***@***.******@***.***>> wrote: This is inaccurate. What the issue we all have is: Bro, I literally described what you had done just without mentioning the "wait till you finish the video" because I literally have this problem either if I do not finish the video or I do finish the video. In your own words within the Actual behavior Sorry, didn't mean to sound snappy at you. I was just frustrated at other people still asking what the issue is 1 year on, when we've all explained what the issue is. — Reply to this email directly, view it on GitHub<#5967 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWXN2ADJJO3SOJQNNZF4JMLU6SLR7ANCNFSM42EJZWPA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[opusforlife2]

@Mjmarahman Sorry, man. Your steps just don't make sense to me.

Step 2. Click on Fullscreen mode. Step 3. It will go horizontal mode. Step 4. Play the video.

How can you do Step 2 before Step 4? The full screen button isn't available if the video isn't already being played.

Try this:

1. Lock your system screen rotation in portrait mode.
2. Make sure Tablet mode is set to Off in Appearances settings.
3. Play a video.
4. Tap the full screen button while the video is playing. (The full screen button is the one next to the seekbar. I'm stating this because your usage of the term is unclear in your comment.) Now you should be in landscape orientation and in full screen.
5. Skip ahead so it finishes quickly. Wait until you see the Replay button.

At this point, what @Frivolous2 said should happen:

if you wait until the video finishes, you are automatically kicked out of fullscreen and locked into landscape

If at any point in the above steps, your device behaves differently than what is written here, then you have some other problem. In that case, please open a new issue and provide a screen recording.

If you get the same behaviour, then congrats, you can come sit with us and wait for this bug to be fixed. :)

[cbiere]

Just a tip: as mentioned in #8135, if you completely ignore the fullscreen button and simply use the manual rotation button, Newpipe doesn't get stuck in landscape orientation. That way takes only one extra tap after a video.

[opusforlife2]

PSA for the unaware: I mentioned this here, but I don't see it explicitly mentioned in this issue:

After the video finishes and exits fullscreen into landscape, don't do anything else. Just tap Back. You should be back in portrait mode, with the video page minimised into the mini player. This way, it also preserves your play queue.

[niktss]

After the video finishes and exits fullscreen into landscape, don't do anything else. Just tap Back. You should be back in portrait mode, with the video page minimised into the mini player. This way, it also preserves your play queue.

[niktss]

Definitely an improvement on how it used to be years ago, but still waiting for a proper fix.

Oops, accidentally closed

[cbiere]

Seems 99% fixed. Even tapping the fullscreen button again during or after the video played, returns NewPipe into portrait mode now. 17 Jul 2022 21:09:06 Frivolous2 ***@***.***>:

…

After the video finishes and exits fullscreen into landscape, /don't do anything else/. Just tap Back. You should be back in portrait mode, with the video page minimised into the mini player. This way, it also preserves your play queue. — Reply to this email directly, view it on GitHub[#5967 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/ACBJQ57FW6PXCO3CEGHEU5LVURK5DANCNFSM42EJZWPA]. You are receiving this because you commented.[Tracking image][https://github.com/notifications/beacon/ACBJQ5ZJALTJEGJIAOIB4JLVURK5DA5CNFSM42EJZWPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOI247CGA.gif]

[opusforlife2]

Indeed. Tapping the full screen button after the video ends, instead of tapping Back, works too.

[Dakkaron]

I still just ignore the fullscreen button completely and instead just use the manual screen rotation button in the navbar.

[opusforlife2]

That's not an option for those who have hardware buttons, though. Unless they specifically enable the navbar and disable their hardware buttons.

[Dakkaron]

Yeah, unless you use Key Remapper to remap rotating the screen to some keys.

I remapped "doubleclick volume up" and "ALT + $" (for when I have the fairberry keyboard attachment on the phone, which is actually almost all of the time).

[TheBrokenRail]

This seems to hsppen to me on my S21 as well. When a video finishes, it halfway exits fullscreen, by which I mean all the comments UI and stuff appears but it doesn't rotate back to portrait. One can complete this half-exit by pressing the fullscreen button, or one can re-enter full-fullscreen by scrolling to earlier in the video.

In my opinion, NewPipe should either fully exit fullscreen when a video finishes, or just stay in fullscreen like the official app. This weird half-fullscreen is just unintuitive.

[HFPasfho]

Right now tapping the "enter to fullscreen mode" button after the video ends is needed to go back to portrait mode. This is so confusing and unintuitive. I can't believe this is considered expected behavior by some people or that this simple bug is unfixed for over two years. NewPipe is a excellent app but this one thing bugs me a lot.

[niktss]

The only way I can see how this could be a minor issue is if you have a newer device with only software buttons. That way, when you physically rotate your screen, a little icon pops up that lets you rotate your phone manually. This is how it works on my Galaxy A52s now, but this option is not available to people with hardware navigation buttons like my old phone, and people running Android Oreo or below. It also takes an extra tap, which is annoying.

If I remember correctly, this was filed as a bug because before v0.21.0, the normal behaviour was the app exiting fullscreen to portrait when rotation was locked, so I genuinely thought this was a bug. As further time passes, it seems more and more like an intentional design decision which NewPipe doesn't want to walk back on

[HFPasfho]

@Frivolous2 If this behavior is intentional I don't know what to say. And it worked reasonable before. Truly incomprehensible decision to change something to worse without any reason and refuse to fix the issue.

[fwsmit]

I don't see any saying this is intentional behavior. It's just that nobody has bothered to create a PR fixing this issue yet.

[Dakkaron]

@fwsmit @HFPasfho There have been one or two attempted fixes (one by me) for this. I don't think this was ever intended behaviour, as evidenced by this bug report still being open and not closed.

But the relevant piece of code is not trivial at all, even though the behaviour looks deceptively trivial.

@HFPasfho Maybe have a look at it, could be you find an easy fix that the others have missed.

NewPipe is a pretty complex work, the code is not easy. And yes, it looks super simple from the user perspective, but there's a lot going on behind the scenes.

Also, afaik there is no monetary incentive behind the app, so work time is at a premium and there 1200 other issues open in the issue tracker, many of which are much more pressing.

For this issue, there is the workaround of ignoring the fullscreen-button and instead use device rotation.

If you want to have this issue be fixed as a priority by the people who actually know the code (read, not me), I am pretty sure a significant donation matching the required work hours could go a long way.

[HFPasfho]

@Dakkaron I'm not the one saying it's intentional behavior. I'm the one who is surprised by such suggestion some people claimed in this thread. Also a "fix it yourself" attitude isn't an inappropriate answer. This is a bug tracker after all and it's for reporting bugs.
Some people claims that this behavior wasn't present in previous builds so someone had to change that. That's why I said it seems to be a simple bug because reverting changes should actually be trivial.

[Dakkaron]

@HFPasfho This is a bugtracker, yes, and the bug has been tracked. It is logged and all the information that could be necessary (from the user view) is already added. So further complaining won't help with fixing the bug.

Also, you are mistaking the attitude. It's not "fix it yourself" but rather "somebody's gotta fix it". This is a free, open-source project. Unless you contributed (either in code or in money) you are just reaping free software from someone else's work.

Which makes you not entitled to command someone else to implement fixes you like. The devs on this project prioritize bugs in accordence to their preferences.

Complaining and maybe even getting offensive will not influence this list of priorities in your favour.

Putting your money where your mouth is might.

A "I am using your free app so I am entitled to dictate what you spend your free time on" attitude is definitely not appropriate.

(Just as a disclaimer, I am not affiliated with NewPipe. I contributed one PR once. I am commenting, because an attitude like yours caused many great opensource devs to give up on opensource work. Please remember, you are reaping the fruit of the unpaid free time work of really gracious open source devs. This app is not developed by some company. You don't pay for it, and frankly, be happy you are allowed to use it for free. You are not entitled to anything at all, and as far as I can see, you haven't contributed anything either.)

[HFPasfho]

@Dakkaron This is some big misunderstanding. I don't speak english and inferring from your response translator must made me sound like an asshole. If that's the case that wasn't my intention. I ended up in this thread because it turned out my problem was described by someone else earlier and my topic has been closed (I couldn't find this issue due to my english). You are right further discussions aren't very helpful at this stage. I gave a thumb up on first comment and I just hope one day this issue will be solved.

[Dakkaron]

@HFPasfho Sorry, the translation is unreckognizably good. So it's not visible that it's a translation.

I just got triggered by that, because as an open source developer you are often target of mobbing due to people treating you like a big company. If you want to, e.g. read up on M66B, who almost shutdown his collection of amazing open source apps after receiving a string of death threats due to people not liking changes he made or didn't make.

In the end, he reduced this to deleting all his public accounts, because he couldn't stand all that anymore.

[HFPasfho]

@Dakkaron It's hard for me to judge the quality of the translation. Good job Google I guess, but judging by your reaction, it probably could have chosen some synonyms better. I didn't mean to cause any harm, so I wrote a disclaimer. But it's a bit pointless to pursue this topic further, so I'll stop there.

[blauertee]

The app treats full screen and Portrait as one and the same thing, doesn't it?
I can imagine that it's quite anoying to fix this then. I mean in a way it's not even wrong, watching a video in Fullscreen also means watching it in portrait mode.
On my phone interacting with the ui in portrait mode when not watching a video is impossibly anoying. Would it be possible to add a setting to disable portrait mode at all except for watching videos in Fullscreen?
I don't think that's a completely clean fix since most people (as this discussion shows) just don't expect this behavior. And the app should at some point have different states for fullscreen-portrait and UI-portrait. But that setting would be nice to have till someone has the time to implement these different states.