Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "Temporary close" button on popup video interface #5952

Closed
3 tasks done
SameenAhnaf opened this issue Mar 29, 2021 · 5 comments
Closed
3 tasks done

Add a "Temporary close" button on popup video interface #5952

SameenAhnaf opened this issue Mar 29, 2021 · 5 comments
Labels
duplicate Issue or discussion is a duplicate of an existing issue or discussion template ignored The user didn't follow the template/instructions (or removed them)

Comments

@SameenAhnaf
Copy link
Collaborator

SameenAhnaf commented Mar 29, 2021

Checklist

Describe the feature you want

A "Temporary close" button could be added in orange doodled space. This button will allow the user to pause the video and close the popup. But it will not clear the queue or hide media player notification bar. If video is resumed from notification, then the video popup will be resumed again.
IMG_20210401_224133

Popup should not be absolutely hidden if paused as we may need to take screenshots from the video or take notes while watching the video. So, adding a separate button for this action will be more appreciated.

Is your feature request related to a problem? Please describe it

Additional context

How will you/everyone benefit from this feature?

It will help us hide the popup temporarily and resume the video a few moments later. Suppose, you received an important message and you need concrete focus. In such case, you won't want to clear the queue. Rather, you will prefer resuming it later. I can resize the video. But I will have to resize and change the position again after I am done which is a little hassle. Adding a separate button could let us avoid the hassle of resizing and popup position.

@SameenAhnaf SameenAhnaf added the feature request Issue is related to a feature in the app label Mar 29, 2021
@chrstfer
Copy link

chrstfer commented Apr 1, 2021

Honestly we need a total queue rework. I keep meaning to write up a compilation of these suggestions and my own thoughts, but always remember just minutes before I'm headed to bed.

If we had a unified queue in the background that would come with the ability to easily background the app without losing the queue by switching to the background playback mode and leaving it paused (and a unified queue that persists when you switch between playback modes would solve a ton of other issues too).

I dont think we need a new UI element to temporarily minimize the app*. The app should just keep your queue by default when you close the popup, and either pause the video or background play it depending on a setting. Queue clearing should be reserved to a manual action or when the app resets (like a force-stop or something).

(*If a specific new UI element is critical, maybe it could use the bubbles feature from Android 11? I'm still not sure what exactly you need it to do that wouldn't happen normally (if we assumed the queue worked as described above). I think it would be pretty cool to have a bubble with the video+related videos just a tap away without leaving the game/app you're in.)

@SameenAhnaf
Copy link
Collaborator Author

@chrstfer I was not talking about multiple queues.

Suppose, I was scrolling Tweets but I need to read something important. What will I do? I will pause the video and prefer to keep it hidden for a few moments. It's not only about switching queues. I may need to multitask while using other apps.

How will I get back to the video? I can get back from media player notification bar.

@chrstfer
Copy link

chrstfer commented Apr 3, 2021

@SameenAhnaf multiple queues just plays into what you're talking about. If we had a fully functional queue system you could dismiss the video popup and get it back at the same time in the video, preserving the queue.

@triallax triallax added GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background) labels Apr 10, 2021
@SameenAhnaf SameenAhnaf reopened this May 1, 2021
@SameenAhnaf
Copy link
Collaborator Author

Duplicate of #1032

@SameenAhnaf SameenAhnaf marked this as a duplicate of #1032 Nov 23, 2022
@SameenAhnaf SameenAhnaf added template ignored The user didn't follow the template/instructions (or removed them) duplicate Issue or discussion is a duplicate of an existing issue or discussion and removed feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background) labels Nov 23, 2022
@opusforlife2
Copy link
Collaborator

xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issue or discussion is a duplicate of an existing issue or discussion template ignored The user didn't follow the template/instructions (or removed them)
Projects
None yet
Development

No branches or pull requests

4 participants